558583 - iFrame shims are broken (regression from Firefox 3.5)

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[lxnyce]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3pre) Gecko/20100405 Firefox/3.6.3plugin1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3pre) Gecko/20100405 Firefox/3.6.3plugin1

This worked fine in the stable release of Firefox. I just tried the beta, and this is now completely broken as you will see in the link above. Compare it with IE, Chrome or current stable Firefox to see what it should look like.

Reproducible: Always

Steps to Reproduce:
1.Goto : http://earth-api-samples.googlecode.com/svn/trunk/demos/customcontrols/index.html
2.Note the iframe shim button is missing
Actual Results:  
The iframe shim button is missing

Expected Results:  
There should be two buttons on the screen

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.4pre) Gecko/20100410 Namoroka/3.6.4pre

With dom.ipc.plugins.enabled to false, I see indeed one button.
With dom.ipc.plugins.enabled to true, I found all this text in my clipboard:

The Google Earth Plugin instance could not be created.

Try installing again.

The Google Earth Plugin failed to initialize. Try reloading the page.

If that doesn't help, you can re-install the Google Earth Plugin using this link.

The Google Earth Plugin was recently updated.

We recommend restarting the browser and then loading this page again.

Learn more »

The Google Earth Plugin had an internal error.

Try reloading the page.

The Google Maps API key used on this web site was registered for a different web site. The developer of this web site can generate a new key here.

The Google Earth Plugin failed to initialize. The installation may be damaged. Try installing again.

Download the Google Earth Plugin

Comment 2

[lxnyce]

Please note, you will have to have the Google Earth plugin installed in order to replicate this issue (Windows or Mac only). I have not tried it with any other plugin so I can't verify that it's broken with those.

I tried reverting to the latest build 3.6.3, and it appears to be broken in there as well. I am going to go back a couple more builds to see when it first appeared. I was either running 3.5.x or 3.6.x.

Comment 3

[lxnyce]

I have narrowed it down to a change in 3.5.9 and 3.6.

The image below shows it working in 3.5.9 and broken in 3.6 :
http://img682.imageshack.us/img682/6508/firefoxiframeshims.jpg

Comment 4

[aravindm]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.4) Gecko/20100413 Firefox/3.6.4
It works for me. Reporter, Please try with the latest trunk. http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.4-candidates/

Comment 5

[lxnyce]

I verified that it works in the latest trunk build. Good Job.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.5pre) Gecko/20100415 Namoroka/3.6.5pre

Yes, it is working now with Firefox 3.6 and with Minefield with IPC disabled.
Resolving WFM.

Comment 7

[lxnyce]

I may have spoken prematurely. The main problem of the iframe contents showing up has been resolved, but there is another relating to the same issue. 

Not quite sure I understand the issue, but it was explained here (Stewart Harper has the same issue as I using ExtJS) : http://support.mozilla.com/en-US/forum/1/592741

See the screenshot to see what I mean (working in 3.5.9, broken in 3.6.x):
http://img58.imageshack.us/img58/6438/ge3.jpg

Notice that in the screenshot, that only certain portions of the shim is showing.

Comment 8

[lxnyce]

I found a possible client side solution for those using ExtJS. 
Screenshot of it working here : http://img709.imageshack.us/img709/1373/ge4y.jpg

I posted it on the support page, but for reference, I will repost here :

Ok, a little firebug dom inspection session came up with a good fix, at least for those using ExtJS. Add this code to your css file, and it will show up in the 3.6.X branches of firefox :

.ext-shim {
background-color: #cccccc;
}

Simple and elegant, no modifying of ExtJS required. And your users can use FireFox until it gets fixed internally.

Comment 9

[Kevin Brosnan]

3.6.4 won't have the Google Earth Plugin running as an OOPP. Each plugin that is allowed to be run out of process is whitelisted, see about:config prefs like dom.ipc.plugins.enabled.np*. On the trunk bug 562051 needs to be sorted out first. 

Marking works for me as Firefox 3.6.x won't be running the Google Earth Plugin out of process.