Closed
Bug 558597
Opened 15 years ago
Closed 15 years ago
Implement LIR_stb on PPC and Sparc
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: edwsmith, Assigned: edwsmith)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
|
2.44 KB,
patch
|
leon.sha
:
review+
|
Details | Diff | Splinter Review |
These platforms already implement LIR_ldub2ul (LIR_ldzb) to load unsigned bytes, but don't have equivalent byte-store instructions.
|
Assignee | |
Updated•15 years ago
|
Summary: Implement LIR_stb on PPC, MIPS, and Sparc → Implement LIR_stb on PPC and Sparc
|
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Target Milestone: --- → Future
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #438296 -
Flags: review?(leon.sha)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: has-patch
|
|
Assignee | |
Comment 3•15 years ago
|
||
Remove too-conservative assert.
Attachment #438295 -
Attachment is obsolete: true
Attachment #438346 -
Flags: review?(rreitmai)
Attachment #438295 -
Flags: review?(rreitmai)
|
||
Comment 4•15 years ago
|
||
Comment on attachment 438346 [details] [diff] [review]
(v2) Add support for LIR_stb on PPC
Wondering if its overkill to have another MEMd-like macro that has no assert (and use it for the STB op) thus leaving the MEMd macro as is.
Attachment #438346 -
Flags: review?(rreitmai) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
The assert was invalid, LIR does not have a requirement that offsets on 32bit load/stores must be multiples of 4. (regardless of whether the underlying CPU supports misaligned load/store).
|
|
Assignee | |
Comment 6•15 years ago
|
||
Comment on attachment 438346 [details] [diff] [review]
(v2) Add support for LIR_stb on PPC
PPC patch pushed to nanojit-central
http://hg.mozilla.org/projects/nanojit-central/rev/e2a7f626b351
Attachment #438346 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: has-patch → has-patch, fixed-in-nanojit
|
|
Assignee | |
Comment 7•15 years ago
|
||
Sparc patch in NJ: http://hg.mozilla.org/projects/nanojit-central/rev/1e26f7116dc4
PPC patch in TR: http://hg.mozilla.org/tamarin-redux/rev/a12398b058f9
Sparc patch in TR: http://hg.mozilla.org/tamarin-redux/rev/f435f14cd0c3
Whiteboard: has-patch, fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin
Comment on attachment 438296 [details] [diff] [review]
add LIR_stb for Sparc
Looks good to me.
Attachment #438296 -
Flags: review?(leon.sha) → review+
|
||
Comment 9•15 years ago
|
||
Whiteboard: fixed-in-nanojit, fixed-in-tamarin → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
|
|
||
Comment 10•15 years ago
|
||
|
||
Comment 11•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•