Last Comment Bug 558645 - Port Bug 537290 [Reduce uses of aNode.localName, namespaceURI in XPath generation] to SeaMonkey
: Port Bug 537290 [Reduce uses of aNode.localName, namespaceURI in XPath genera...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Session Restore (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Misak Khachatryan
:
:
Mentors:
Depends on: 537290
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-11 04:16 PDT by Misak Khachatryan
Modified: 2010-04-20 09:05 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.20 KB, patch)
2010-04-11 04:16 PDT, Misak Khachatryan
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description Misak Khachatryan 2010-04-11 04:16:13 PDT
Created attachment 438345 [details] [diff] [review]
patch

From parent bug:

These hit "various XPConnect slow paths due to the cross-origin access" - bz in
bug 536910 comment #29

We access these each iteration in a loop (counting sibling nodes) and once
before even getting in the loop. We can take bring that down to 1 total per
node (I don't think we can get rid accessing these in the sibling nodes).

I ran test on my Fedora 12, no failed test seen.
Comment 1 neil@parkwaycc.co.uk 2010-04-11 04:32:40 PDT
Comment on attachment 438345 [details] [diff] [review]
patch

>     let nName = aNode.name || null;
[I don't like that nNaming convention ;-) Too late now.]
Comment 2 Misak Khachatryan 2010-04-20 00:06:32 PDT
Pushed http://hg.mozilla.org/comm-central/rev/3778517be974

Note You need to log in before you can comment on or make changes to this bug.