Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Port Bug 537290 [Reduce uses of aNode.localName, namespaceURI in XPath generation] to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.20 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 438345 [details] [diff] [review]
patch

From parent bug:

These hit "various XPConnect slow paths due to the cross-origin access" - bz in
bug 536910 comment #29

We access these each iteration in a loop (counting sibling nodes) and once
before even getting in the loop. We can take bring that down to 1 total per
node (I don't think we can get rid accessing these in the sibling nodes).

I ran test on my Fedora 12, no failed test seen.
Attachment #438345 - Flags: superreview?(neil)
Attachment #438345 - Flags: review?(neil)

Comment 1

7 years ago
Comment on attachment 438345 [details] [diff] [review]
patch

>     let nName = aNode.name || null;
[I don't like that nNaming convention ;-) Too late now.]
Attachment #438345 - Flags: superreview?(neil)
Attachment #438345 - Flags: superreview+
Attachment #438345 - Flags: review?(neil)
Attachment #438345 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

7 years ago
Pushed http://hg.mozilla.org/comm-central/rev/3778517be974
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a1
You need to log in before you can comment on or make changes to this bug.