558680 - Exceptions from _respond_with_pkg_file result in confusing errors in the UI

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Nickolay_Ponomarev]

Attachment: use traceback.format_exc() instead of just stringifying the exception

After a recent update I got into state where the nsjetpack module was both in atul-packages and in the mainline hg repository.

What should have been reported as:

Traceback (most recent call last):
File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/server.py", line 169, in _respond_with_pkg_file pkg_cfg = self.build_pkg_cfg()
File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/server.py", line 160, in build_pkg_cfg Bunch(name='dummy'))
File "/Users/nickolay/dev/jetpack-sdk/python-lib/cuddlefish/packaging.py", line 145, in build_config raise DuplicatePackageError(path, otherpkg.root_dir) 

DuplicatePackageError: ('/Users/nickolay/dev/jetpack-sdk/packages/atul-packages/packages/nsjetpack', '/Users/nickolay/dev/jetpack-sdk/packages/nsjetpack') 

was actually reported as 
('/Users/nickolay/dev/jetpack-sdk/packages/atul-packages/packages/nsjetpack', '/Users/nickolay/dev/jetpack-sdk/packages/nsjetpack') 

in the left sidebar of 'cfx docs' page.

Comment 1

[Atul Varma [:atul]]

Thanks for the patch! Pushed:

  http://hg.mozilla.org/labs/jetpack-sdk/rev/f01a5fecf277

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".