55872 - Standalone mail window omits cmd-M for new message

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Mike Pinkerton (not reading bugmail)]

in the standalone mail message window, File:New Message doesn't have a cmd-key
eqivalent, so hitting cmd-m does nothing, unlike every other window where it
opens a new mail message compose window.

Comment 1

[Mike Pinkerton (not reading bugmail)]

this should be a real trivial fix, I think we should get this for rtm.

Comment 2

[selmer (gone)]

Perhaps the fix is trivial, but that doesn't justify fixing it in rtm since
there are thousands of trivial fixes we could do.  The odds of needing to use
this shortcut from this window seem small.  The best argument for fixing this is
to have UI consistency, but I don't think that's compelling in the time remaining.

rtm- unless there's a compelling argument.

Comment 3

[Mike Pinkerton (not reading bugmail)]

odds of needing to use the shortcut? I'd say 1:1. I need it every day. I read
mail with a standalone window, and if it's in the front, i can't use cmd-m to
write new mail.

It's very annoying.

Comment 4

[scottputterman]

marking [rtm-]. There are other ways to create a new mail message from that window.

Comment 5

[scottputterman]

nominating mail3 and reassigning to sspitzer

Comment 6

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8.  changing summary to refer to
standalone mail window which I think is what this bug is referring to.

Comment 7

[scottputterman]

reassigning to ssu

Comment 8

[scottputterman]

moving to mozilla0.9

Comment 9

[scottputterman]

marking nsbeta1-.  it's getting marked nsbeta1- but I will try to find someone
to fix this.

Comment 10

[Mark Anderson]

Seems to me this'd be really simple to do.  I'm willing to do it in my first 
crack at XUL if it's truly as trivial as it sounds (wouldn't it be the addition 
of a whopping one attribute to one tag in one file?).  Finding the right file is 
probably the hardest part. :)

Comment 11

[Mark Anderson]

Attachment: Proposed patch for 55872

Comment 12

[Mark Anderson]

The above is a patch to include mailOverlay.xul as an overlay in this file.  
Near as I can tell (from 10 minutes in the XUL code), that's the way the main 
mail window does it, and any potential change to the shortcut (or if shortcuts 
are added for New Folder, etc.) should be properly reflected.  It works (in the 
all of one test I knew to run :) ), but is this the correct solution?

Comment 13

[timeless]

r=timeless

Comment 14

[timeless]

reassign

Comment 15

[(not reading, please use [e-mail] instead)]

fixed checked in.  sorry for the delay.  thanks for the fix.

Comment 16

[Blake Ross]

Is everyone here sure that overlayed another file here was the right fix?  Does 
it have other benefits?  If it was just for the one accelerator, surely the 
cost of the overlay far outweighs the wrongness of one-line code duplication?

Comment 17

[Mark Anderson]

Well, insofar as I could tell, this was the same way the main mail window was 
getting its accelerators and other assorted goodies that for some reason aren't 
in mailWindowOverlay.xul (which looked to be included in every mail window, and 
mailOverlay.xul was in all but the standalone msg window).  With timeless 
cleaning up the UI for that anyway, this patch probably won't last until 1.0 
because the correct fix, insofar as I could tell, would be to merge the 
functionality of mailOverlay.xul into mailWindowOverlay.xul.

The code duplication would be slightly more than one line anyway, since the 
handling of the modifier is also done in mailOverlay.xul (sure, it would be a 
one line fix to add the modifier to messageWindow.xul, but it wouldn't do 
anything without basically the entire contents of mailOverlay.xul anyway).

Of course, since I know approximately as much XUL as this patch took, my 
understanding could be way off (especially since I'm utterly unfamilar with the 
mail/news architecture). :)

Comment 18

[Blake Ross]

> (sure, it would be a one line fix to add the modifier to messageWindow.xul, 
> but it wouldn't do anything without basically the entire contents of 
> mailOverlay.xul anyway).

Why?  It should be as simple as <key id="foo" key="m" modifiers="control" 
oncommand="msgCompose();"/> (localizable, of course) or something similar.

I appreciate the patch, I just want to ensure that we aren't doing extra work 
here for little gain.

Comment 19

[Ninoschka Baca]

Build 2001-02-19-08: NT4, Linux RH 6.2, Mac 9.04
Verified Fixed, thanks!