URL's hardcoded in extensions.js

VERIFIED FIXED in mozilla1.9.3a5

Status

()

--
trivial
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: alfredkayser, Assigned: mossop)

Tracking

unspecified
mozilla1.9.3a5
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [AddonsRewrite])

(Reporter)

Description

9 years ago
In extensions.js there is:
1495 if (!iconURL) {
1496 iconURL = isTheme ? "chrome://mozapps/skin/extensions/themeGeneric.png" :
1497 "chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png";
1498 }
While these URL's are also defined in top of the file:
113 const URI_GENERIC_ICON_XPINSTALL = "chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png";
114 const URI_GENERIC_ICON_THEME = "chrome://mozapps/skin/extensions/themeGeneric.png";

So, the hardcoded URL's should be replaced by their defines:
1495 if (!iconURL) {
1496 iconURL = isTheme ? URI_GENERIC_ICON_THEME : URI_GENERIC_ICON_XPINSTAL;
1498 }
(Reporter)

Updated

9 years ago
Depends on: 411479
(Assignee)

Comment 1

8 years ago
This is fixed in the new extension manager
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Dave, this is the entry from the install.rdf, i.e.?

<em:iconURL>chrome://acr/skin/images/star32.png</em:iconURL>
(Assignee)

Comment 3

8 years ago
We used to fall back to the default icon in extensions.js, now that is handled by the stylesheet in the theme: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/mozapps/extensions/extensions.css#312
Thanks. Marking as verified.
Assignee: nobody → dtownsend
Status: RESOLVED → VERIFIED
Depends on: 553169
No longer depends on: 411479
Flags: in-testsuite?
Flags: in-litmus-
Whiteboard: [AddonsRewrite]
Target Milestone: --- → mozilla1.9.3a5
(Assignee)

Comment 5

8 years ago
Verified by inspection, no need for an automated test.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.