558763 - [e10s] Quick search from the address bar doesn't work

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[chithraprabha]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.18) Gecko/2010021501 Ubuntu/9.04 (jaunty) Firefox/3.0.18
Build Identifier: 

Quick search from the address bar doesn't work with electrolysis.

Reproducible: Always

Steps to Reproduce:
Open fennec and type some search words in the address bar and click go 
button.


Actual Results:  
Nothing happens.

Expected Results:  
Search results page is displayed.

below  exception occurs ,when the go button is pressed, 

"""WARNING: malformed hostname: file /home/chithrp/E10s/electrolysis/netwerk/base/src/nsURLParsers.cpp, line 606
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIURIFixup.createFixupURI]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: chrome://browser/content/browser-ui.js :: anonymous :: line 436"  data: no] """

Comment 1

[Josh Matthews [:jdm]]

I suspect this can be resolved the same way as bug 554271.

Comment 2

[chithraprabha]

Attachment: Patch V.0

With this patch quick search works fine .

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 447294 [details] [diff] [review]
Patch V.0


>-    let uri = gURIFixup.createFixupURI(aURI, 0);
>+    let  fixupFlags = gURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP;
>+    let uri = gURIFixup.createFixupURI(aURI, fixupFlags);
> 
>     var flags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP;
>     getBrowser().loadURIWithFlags(uri.spec, flags, null, null);

nits: extra space in "let  fixupFlags"
      use Ci.nsIURIFixup.FIXUP_FLAG...
      change "var flags" to "let loadFlags"

I can make the nit changes when landing

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

ushed to mobile-e10s:
http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/88f97721f8bb

This patch should be safe for mobile-browser too, and landing it there would remove it from the "merge pain".

mobile-browser patch coming up

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed sync patch to m-b:
http://hg.mozilla.org/mobile-browser/rev/84ea374b8a00