Verifier::checkTarget(current, target) needs cleanup

NEW
Unassigned

Status

Tamarin
Verifier
8 years ago
7 years ago

People

(Reporter: Edwin Smith, Unassigned)

Tracking

unspecified
Future
Bug Flags:
flashplayer-qrb +

Details

(Reporter)

Description

8 years ago
The parameter "current" is only used to detect back edges, yet is passed is a pointer, and can point outside the bytecode area when checkTarget() is called for fall-through blocks.  This is fragile, a future change could naively dereference current and crash or read invalid data.  

It might be a good idea to distinguish fall-through paths from branch paths, and simplify checkTarget for fall-through paths since they cannot be back edges.
(Reporter)

Updated

8 years ago
Depends on: 558442
Target Milestone: --- → Future
(Reporter)

Updated

8 years ago
Component: Virtual Machine → Verifier

Updated

7 years ago
Assignee: nobody → edwsmith
Flags: flashplayer-qrb+
(Reporter)

Comment 1

7 years ago
Still valid, and FIXME is still in the code.  Linking to the Code Cleanup tracker.
Assignee: edwsmith → nobody
You need to log in before you can comment on or make changes to this bug.