Closed Bug 558876 Opened 14 years ago Closed 6 years ago

Verifier::checkTarget(current, target) needs cleanup

Categories

(Tamarin Graveyard :: Verifier, defect)

Product:
Tamarin Graveyard
Component:
Verifier
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

The parameter "current" is only used to detect back edges, yet is passed is a pointer, and can point outside the bytecode area when checkTarget() is called for fall-through blocks.  This is fragile, a future change could naively dereference current and crash or read invalid data.  

It might be a good idea to distinguish fall-through paths from branch paths, and simplify checkTarget for fall-through paths since they cannot be back edges.
Depends on: 558442
Target Milestone: --- → Future
Component: Virtual Machine → Verifier
Assignee: nobody → edwsmith
Flags: flashplayer-qrb+
Still valid, and FIXME is still in the code.  Linking to the Code Cleanup tracker.
Assignee: edwsmith → nobody
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in before you can comment on or make changes to this bug.