Closed Bug 558887 Opened 10 years ago Closed 10 years ago
.exe doesn't get a manifest
Seems like VC10's link.exe wants the manifest to exist in the object directory, not the source directory. Copying the manifest normally, then running make causes the manifest to be embedded (and the manifest file to be deleted :| )
Which manifest? The .manifest file is an *output* of link.exe, not an input. After link runs, we then embed the manifest using mt.exe. Can you paste the build log of what exactly is failing?
(In reply to comment #1) > Which manifest? http://mxr.mozilla.org/mozilla-central/source/config/nsinstall.exe.manifest > After link runs, we then embed the manifest using mt.exe. > > Can you paste the build log of what exactly is failing? $ make make export make: Entering directory `/c/Users/Sid/mozilla/thunderbird-trunk/mozilla/config' make: Entering directory `/c/Users/Sid/mozilla/thunderbird-trunk/mozilla/config/mkdepend' make: Nothing to be done for `export'. make: Leaving directory `/c/Users/Sid/mozilla/thunderbird-trunk/mozilla/config/mkdepend' nsinstall_win.c cl -Fohost_nsinstall_win.obj -c -TC -nologo -W3 -Gy -Fdgenerated.pdb -DDEBUG -D_DEBUG -DDEBUG_Sid -DTRA CING -Zi -TC -nologo -Fdhost_nsinstall_win.pdb -DXP_WIN32 -DXP_WIN -DWIN32 -D_WIN32 -DNO_X11 -MDd -DUNICODE -D_UNICODE -I../../../src-trunk/mozilla/config -I. -I../dist/include -I../dist/include/nsprp ub -Ic:/Users/Sid/mozilla/thunderbird-trunk/mozilla/dist/include/nspr -Ic:/Users/Sid/mozilla/thunderbird -trunk/mozilla/dist/include/nss -Ic:/Users/Sid/mozilla/thunderbird-trunk/mozilla/dist/include/nspr / c/Users/Sid/mozilla/src-trunk/mozilla/config/nsinstall_win.c cl : Command line warning D9025 : overriding '/Fdgenerated.pdb' with '/Fdhost_nsinstall_win.pdb' nsinstall_win.c <warnings snipped> link -NOLOGO -OUT:nsinstall.exe -PDB:nsinstall.pdb host_nsinstall_win.obj c:/Users/Sid/mozilla/thunderbird-trunk/mozilla/config/nsinstall.exe -m 644 ../mozilla-config.h ../../../s rc-trunk/mozilla/config/nsStaticComponents.h ../dist/include make: execvp: c:/Users/Sid/mozilla/thunderbird-trunk/mozilla/config/nsinstall.exe: Bad file number make: *** [export] Error 127 make: Leaving directory `/c/Users/Sid/mozilla/thunderbird-trunk/mozilla/config' make: *** [all] Error 2
What is MSMANIFEST_TOOL? http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1047 should be running here, assuming everything is configured correctly.
(In reply to comment #3) > What is MSMANIFEST_TOOL? 1 > http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1047 should be > running here, assuming everything is configured correctly. The logic there seems incorrect, because it first tests for existence in the current directory. That fails, and everything goes downhill from there.
Then you need to port bug 545892 to the HOST_PROGRAM block: normally the linker will generate the .manifest, but apparently in your case it does not.
yeah, that works.
Attachment #438577 - Flags: review?(benjamin)
Assignee: nobody → sid.bugzilla
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Ported to comm-central: http://hg.mozilla.org/comm-central/rev/9ecee87ecb58
You need to log in before you can comment on or make changes to this bug.