Closed
Bug 558944
Opened 14 years ago
Closed 14 years ago
nsNodeInfoManager should not do atomic incr/decr in its refcounting code
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file, 1 obsolete file)
|
1.76 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Stumbled on this looking at profiling data for something unrelated. This probably doesn't have much of an impact on perf, since these objects should really not be refcounted much at all, but still, it's wasteful and not necessary to do atomic operations in this code.
Attachment #438613 -
Flags: review?(jonas)
|
Assignee | |
Comment 1•14 years ago
|
||
Or we could use fancy macros if we have ones that would work here...
Could you use the new NS_INLINE_DECL_REFCOUNTING macro? http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsISupportsImpl.h#315
|
|
Assignee | |
Comment 3•14 years ago
|
||
Yeah, that seems to work excellent here.
Attachment #438613 -
Attachment is obsolete: true
Attachment #438637 -
Flags: review?(jonas)
Attachment #438613 -
Flags: review?(jonas)
Comment on attachment 438637 [details] [diff] [review] Don't do atomic incr/decr, and use existing macro. r=me
Attachment #438637 -
Flags: review?(jonas) → review+
|
||
Comment 5•14 years ago
|
||
Fixed on mozilla-central: http://hg.mozilla.org/mozilla-central/rev/f743ed8fb2c5
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•