Autoscroll doesn't take into account overflow: -moz-hidden-unscrollable;

VERIFIED FIXED

Status

()

Toolkit
XUL Widgets
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Swatinem)

Tracking

({testcase})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 438614 [details]
testcase

Besides overflow: hidden, overflow:scroll, overflow:auto and overflow: visible, there is also the computed value of overflow:-moz-hidden-unscrollable.
The new autoscroll code should probably also take that into account, because now autoscrolling doesn't work with those values.
(Assignee)

Comment 1

8 years ago
Created attachment 438699 [details] [diff] [review]
fix [pushed: comment 4]

Instead of disallowing scrolling on "hidden" or "visible", I changed it around to allow scrolling only when "scroll" or "auto" is present.
Are there any other special values I need to be aware of?
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attachment #438699 - Flags: review?(neil)
(Reporter)

Comment 2

8 years ago
See https://developer.mozilla.org/en/CSS/overflow
It turns out there are also these values:
-moz-scrollbars-none, -moz-scrollbars-horizontal and -moz-scrollbars-vertical.
But for those values, the computed values are 'converted' into 'hidden' and 'scroll', so they already work correctly.

Updated

8 years ago
Attachment #438699 - Flags: review?(neil) → review+

Comment 3

8 years ago
Comment on attachment 438699 [details] [diff] [review]
fix [pushed: comment 4]

>+            // this is a list of values to the overflow property that allow
>+            // scrolling
s/values to the overflow property/overflow property values/
(does that allow you to fit the comment in on one line? if not my other suggestion is // this is a list of scrollable overflow property values)
(Assignee)

Updated

8 years ago
Attachment #438699 - Attachment description: fix → fix [pushed: comment 4]
(Assignee)

Comment 4

8 years ago
Comment on attachment 438699 [details] [diff] [review]
fix [pushed: comment 4]

Pushed with comment adressed: http://hg.mozilla.org/mozilla-central/rev/d51871338856
Thanks!
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

8 years ago
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100419 Minefield/3.7a5pre

Thanks Arpad.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.