558949 - Make ctypes functions FunctionType.ptr's

Status: RESOLVED FIXED

(Core :: js-ctypes, defect, P1)

Comment 1

[[e-mail]]

Originally I made FunctionTypes be function pointers directly, since that's the way they're used. But jorendorff thinks, and I now agree, that we should have FunctionType be non-instantiable as data... instead, one uses a FunctionType.ptr.

This is a significant API change, so we need it for 1.9.3.

Comment 2

[[e-mail]]

CC'ing sheppy, since this might be relevant to his efforts.

Per above, this change will break ctypes code that makes use of FunctionType directly. (library.declare usage will remain the same.)

I don't think this applies to you, but if it does, please speak up. :)

Comment 3

[Eric Shepherd [:sheppy]]

If nothing else, it will certainly be doc relevant.

Comment 4

[[e-mail]]

Attachment: like so

Fun times.

Comment 5

[Ben Newman (:bnewman) (:benjamn)]

Comment on attachment 440088 [details] [diff] [review]
like so

Looks good (and adequately tested) to me.

Comment 6

[[e-mail]]

Comment on attachment 440088 [details] [diff] [review]
like so

http://hg.mozilla.org/tracemonkey/rev/4d2c12947055

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/4d2c12947055