Closed
Bug 558953
Opened 16 years ago
Closed 16 years ago
locale missing from personas links under 'More Personas' section
Categories
(Websites Graveyard :: getpersonas.com, defect)
Websites Graveyard
getpersonas.com
Tracking
(Not tracked)
VERIFIED
FIXED
2.7
People
(Reporter: vish_moz, Assigned: janitux)
References
()
Details
Attachments
(2 files, 1 obsolete file)
|
363.20 KB,
image/png
|
Details | |
|
1.63 KB,
patch
|
rdoherty
:
review+
|
Details | Diff | Splinter Review |
locale missing from personas links under 'More Personas' section
STR:
1. go to personas stage, http://personas.stage.mozilla.com/en-US/
2. click on 'Gallery'
3. click on any persona, for eg http://personas.stage.mozilla.com/en-US/persona/31238
4. Hover over one of the personas under the 'More Fashion Personas' and notice the personas links on the status bar of the browser
Actual result:
links look like http://personas.stage.mozilla.com/persona/810 (links are missing loclae )
Expected result:
link should look like http://personas.stage.mozilla.com/en-US/persona/810
Updated•16 years ago
|
Assignee: rdoherty → janitux
Target Milestone: --- → 2.7
| Assignee | ||
Comment 1•16 years ago
|
||
Attachment #439409 -
Flags: review?(rdoherty)
Comment 2•16 years ago
|
||
Comment on attachment 439409 [details] [diff] [review]
Proposed patch
This fixes one module, but misses the section for other personas by the same designer.
Example link:
http://personas.stage.mozilla.com/en-US/persona/32760
Attachment #439409 -
Flags: review?(rdoherty) → review-
| Assignee | ||
Comment 3•16 years ago
|
||
V2, i missed that detail, thanks ryan :)
Attachment #439409 -
Attachment is obsolete: true
Attachment #439413 -
Flags: review?(rdoherty)
Comment 4•16 years ago
|
||
Comment on attachment 439413 [details] [diff] [review]
Proposed patch v2
looks good!
Attachment #439413 -
Flags: review?(rdoherty) → review+
| Assignee | ||
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Product: Websites → Websites Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•