558960 - Unable to save folder name change to "Desktop Bookmarks"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Tony Chung [:tchung]]

After syncing via weave to fennec 1.1a2pre, the "Desktop Bookmarks" folder gets generated in the bookmarks list.  However, i am unable to edit and save a change to the "Desktop Bookmarks" title

Repro:
1) install Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre)
Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre
2) install weave 1.2 extension and sync to existing account from firefox
3) after syncing, open bookmarks
4) At the top, should have an entry for "Desktop Bookmarks"
5) click Manage, and edit that entry
6) type in whatever you want, but verify you cannot complete the changes with "Done".  With other bookmarks, you can edit the title and click "Done"

Expected:
- click Done

Actual:
- cannot click Done

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I don't think we want to be able to edit this row at this time. This patch prevent to edit the "Desktop Bookmarks" row.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)

> I don't think we want to be able to edit this row at this time. This patch
> prevent to edit the "Desktop Bookmarks" row.

Agreed

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 438745 [details] [diff] [review]
Patch

rename _fakeDesktopFolderId -> _desktopFolderId

I'll do it on checkin

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8a2a9932232a

Comment 5

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100414 Namoroka/3.6.5pre Fennec/1.1a2pre