Closed Bug 558960 Opened 10 years ago Closed 10 years ago

Unable to save folder name change to "Desktop Bookmarks"

Categories

(Firefox for Android Graveyard :: Bookmarks, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tchung, Assigned: vingtetun)

Details

Attachments

(1 file)

After syncing via weave to fennec 1.1a2pre, the "Desktop Bookmarks" folder gets generated in the bookmarks list.  However, i am unable to edit and save a change to the "Desktop Bookmarks" title

Repro:
1) install Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre)
Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre
2) install weave 1.2 extension and sync to existing account from firefox
3) after syncing, open bookmarks
4) At the top, should have an entry for "Desktop Bookmarks"
5) click Manage, and edit that entry
6) type in whatever you want, but verify you cannot complete the changes with "Done".  With other bookmarks, you can edit the title and click "Done"

Expected:
- click Done

Actual:
- cannot click Done
Attached patch PatchSplinter Review
I don't think we want to be able to edit this row at this time. This patch prevent to edit the "Desktop Bookmarks" row.
Assignee: nobody → 21
Attachment #438745 - Flags: review?(mark.finkle)
(In reply to comment #1)

> I don't think we want to be able to edit this row at this time. This patch
> prevent to edit the "Desktop Bookmarks" row.

Agreed
Comment on attachment 438745 [details] [diff] [review]
Patch

rename _fakeDesktopFolderId -> _desktopFolderId

I'll do it on checkin
Attachment #438745 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/8a2a9932232a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fix on Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100414 Namoroka/3.6.5pre Fennec/1.1a2pre
You need to log in before you can comment on or make changes to this bug.