Closed Bug 558979 Opened 14 years ago Closed 14 years ago

"ASSERTION: What kind of object is this" with appendChild, setting __proto__

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5
Tracking Status
blocking2.0 --- final+

People

(Reporter: jruderman, Assigned: peterv)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: What kind of object is this?: 'IS_SLIM_WRAPPER_OBJECT(currentJSObject)', file /Users/jruderman/mozilla-central/js/src/xpconnect/src/xpcinlines.h, line 802

I'm guessing this is another regression from bug 540848.
Attached file stack traces
blocking2.0: --- → ?
Assignee: nobody → peterv
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a5
Attached patch v1Splinter Review
I messed this up a bit while refactoring. We need to pass the wrapper's obj to setWrapper. __proto__ has been set so in this case it's different from JS_THIS_OBJECT (we get it from the callee's parent). Also, castNativeFromWrapper still uses variables with "this" in the name but it's also used for args, so I renamed them.
Attachment #438703 - Flags: review?(mrbkap)
Attachment #438703 - Flags: review?(mrbkap) → review+
http://hg.mozilla.org/mozilla-central/rev/0620646abec8
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
blocking2.0: ? → final+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: