Port |Bug 518641 - "make package-tests" doesn't work right on OS X universal builds| to comm-1.9.1

RESOLVED FIXED

Status

MailNews Core
Build Config
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

1.9.1 Branch
All
Mac OS X
Dependency tree / graph
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.0 .5-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Port bug 526817 patch Bv1 too.

See discussion in bug 526817.
Flags: in-testsuite-
(Assignee)

Comment 1

7 years ago
Created attachment 438786 [details] [diff] [review]
(Av1) Port it, With bug 526817 too
[Checkin: Comment 5]

Per your bug 526817 comment 10.
Attachment #438786 - Flags: approval-thunderbird3.0.5?

Comment 2

7 years ago
What exactly doesn't work on 1.9.1 without this? I see our packaged tests working quite well on SeaMonkey2.0, so I wonder what's up here.
(Assignee)

Comment 3

7 years ago
Comment on attachment 438786 [details] [diff] [review]
(Av1) Port it, With bug 526817 too
[Checkin: Comment 5]

(In reply to comment #2)
> What exactly doesn't work on 1.9.1 without this?

What's not clear in my bug 526817 comment 12?

>+else
>+package-tests::
>+	$(MAKE) -C mozilla $@

Needed to match
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/59e1a6f8fd05

>+	      --unify-with-sort "all-test-dirs\.list$$" \

Wanted to prevent oranges.
Attachment #438786 - Flags: approval-thunderbird3.0.5? → approval-thunderbird3.0.5+
Note: that a+ is subject to this not breaking the Thunderbird tinderboxes. If it is going to break them then it should wait until we've picked up the latest m-1.9.1 code.
(Assignee)

Updated

7 years ago
status-thunderbird3.0: --- → ?
Keywords: checkin-needed
Whiteboard: [c-n: see comment (3 and) 4]
Checked in: http://hg.mozilla.org/releases/comm-1.9.1/rev/b237aadcfb4c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
status-thunderbird3.0: ? → .5-fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: see comment (3 and) 4]
(Assignee)

Updated

7 years ago
Attachment #438786 - Attachment description: (Av1) Port it, With bug 526817 too → (Av1) Port it, With bug 526817 too [Checkin: Comment 5]
Verifying as this is build config only and hasn't affected the builds.
Keywords: verified-thunderbird3.0
You need to log in before you can comment on or make changes to this bug.