Can't clear search history with Weave 1.2.1

VERIFIED FIXED in 1.3b1

Status

Cloud Services
Firefox Sync: UI
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Nick B., Assigned: Mardak)

Tracking

({regression})

unspecified
1.3b1
regression
Points:
---
Bug Flags:
blocking-weave1.3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100402 Ubuntu/9.10 (karmic) Firefox/3.5.9
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100402 Ubuntu/9.10 (karmic) Firefox/3.5.9

With one of the latest Weave updates (either 1.2.0 or 1.2.1) the Clear Search History option in the right click menu of the search bar is completely broken. It's always grayed out. The only way to get it to work again is to disable Weave.

Reproducible: Always

Steps to Reproduce:
1. Perform a few searches through the search bar.
2. Right click in the search bar and attempt to clear your search history
3.
Actual Results:  
The "Clear Search History" option is grayed out and cannot be clicked.

Expected Results:  
I should be able to clear my search history.

Also reproducible on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100409 Ubuntu/10.04 (lucid) Firefox/3.6.3 with Weave 1.2.1

Comment 1

8 years ago
I confirm this bug with Weave 1.2.1 and Firefox 3.6.3 on Win XP Pro:
Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

Comment 2

8 years ago
Adding a Me Too: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.5.9-2.fc12 Firefox/3.5.9
I don't have this immediately after a restart, but it eventually happens.
Assignee: nobody → edilee
Status: UNCONFIRMED → NEW
Component: Needs Triage → Firefox UI
Ever confirmed: true
Keywords: regression
OS: Linux → All
QA Contact: needstriage → firefox
Hardware: x86_64 → All
Target Milestone: --- → 1.3

Updated

8 years ago
Flags: blocking-weave1.3+
(Assignee)

Comment 4

8 years ago
Created attachment 439277 [details] [diff] [review]
v1

:(
Attachment #439277 - Flags: review?(mconnor)

Updated

8 years ago
Attachment #439277 - Flags: review?(mconnor) → review+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/labs/weave/rev/696e010d8093
Return any value provided by the base form implementation while making sure we still notify before and after the call.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
clear form history there was a tad slow, but it eventually got cleared. verified on Mac and Windows with Weave 1.3b1
Status: RESOLVED → VERIFIED

Updated

8 years ago
Target Milestone: 1.3 → 1.3b1
You need to log in before you can comment on or make changes to this bug.