559130 - Can't clear search history with Weave 1.2.1

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Nick B.]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100402 Ubuntu/9.10 (karmic) Firefox/3.5.9
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100402 Ubuntu/9.10 (karmic) Firefox/3.5.9

With one of the latest Weave updates (either 1.2.0 or 1.2.1) the Clear Search History option in the right click menu of the search bar is completely broken. It's always grayed out. The only way to get it to work again is to disable Weave.

Reproducible: Always

Steps to Reproduce:
1. Perform a few searches through the search bar.
2. Right click in the search bar and attempt to clear your search history
3.
Actual Results:  
The "Clear Search History" option is grayed out and cannot be clicked.

Expected Results:  
I should be able to clear my search history.

Also reproducible on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100409 Ubuntu/10.04 (lucid) Firefox/3.6.3 with Weave 1.2.1

Comment 1

[Andrea]

I confirm this bug with Weave 1.2.1 and Firefox 3.6.3 on Win XP Pro:
Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

Comment 2

[Michael Cronenworth]

Adding a Me Too: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.5.9-2.fc12 Firefox/3.5.9

Comment 3

[Mike Connor [:mconnor]]

I don't have this immediately after a restart, but it eventually happens.

Comment 4

[Ed Lee :Mardak]

Attachment: v1

:(

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/696e010d8093
Return any value provided by the base form implementation while making sure we still notify before and after the call.

Comment 6

[Tracy Walker [:tracy]]

clear form history there was a tad slow, but it eventually got cleared. verified on Mac and Windows with Weave 1.3b1