Closed Bug 559229 Opened 11 years ago Closed 11 years ago

Hard coded access key in Personas

Categories

(Mozilla Labs Graveyard :: Personas Plus, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: joradan0, Assigned: jose)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 GTB6 (.NET CLR 1.0.3705; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.30; .NET CLR 3.0.04506.648; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729)
Build Identifier: Personas 1.5.3 in Firefox and Thunderbird

In Thunderbird: When you press the 'Wear' button an 'Undo' button appears. The access key for this is U. I have localized this access key to o in the Danish version. I think it is hard coded.

In Firefox: If you choose a Persona from the Persona icon in the statusbar, you see the 'Undo' button with the access key U. This is wrong. The access key should be o. (In the Danish version).

I don't think that the string 'notification.revertButton.accesskey=o' in personas.properties are used.

Reproducible: Always

Actual Results:  
The access key is U

Expected Results:  
The access key displayed should be the translated access key. In the danish version o.

This bug has been present in 1.5 1.5.2 and in 1.5.3
Confirmed on Firefox 3.6.3 with Personas 1.5.3 on Windows XP [Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 (.NET CLR 3.5.30729)].
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: -- → 1.6
Fixed in rev:
http://hg.mozilla.org/labs/personas/rev/b2ef5158aedd
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: cbeard → jose
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.