559250 - encapsulate JSSLOT_{PRIMITIVE,DATE,REGEXP}_* within JSObject

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

Pretty straightforward.  Only tricky bit is that I inline
GetRegExpLastIndex() and GetRegExpLastIndexValue() before converting them;
I did this because they both had a single call site.

Comment 1

[Brendan Eich [:brendan]]

Comment on attachment 438928 [details] [diff] [review]
patch

"jsval *" not "jsval*" throughout, and if you got busted by Waldo for {inc,dec} instead of {increase,decrease} previously, how will addr instead of addressOf go over?

r=me with these nits picked.

/be

Comment 2

[Nicholas Nethercote [inactive]]

Pushed with nits picked:

http://hg.mozilla.org/tracemonkey/rev/681b0067e61b

Comment 3

[Nicholas Nethercote [inactive]]

Backed out:

http://hg.mozilla.org/tracemonkey/rev/5da61a630e98

Weird.  Compiles fine on my Linux box and Mac, but turned the entire tinderbox red.  #include problems.  Maybe I'll fix bug 558723 first.

Comment 4

[Nicholas Nethercote [inactive]]

Turns out I'd only done shell builds, and the failure was in a browser build.

http://hg.mozilla.org/tracemonkey/rev/15da2440d2b0

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/15da2440d2b0