Closed Bug 559250 Opened 10 years ago Closed 10 years ago

encapsulate JSSLOT_{PRIMITIVE,DATE,REGEXP}_* within JSObject

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: njn, Assigned: njn)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch patchSplinter Review
Pretty straightforward.  Only tricky bit is that I inline
GetRegExpLastIndex() and GetRegExpLastIndexValue() before converting them;
I did this because they both had a single call site.
Attachment #438928 - Flags: review?(brendan)
Comment on attachment 438928 [details] [diff] [review]
patch

"jsval *" not "jsval*" throughout, and if you got busted by Waldo for {inc,dec} instead of {increase,decrease} previously, how will addr instead of addressOf go over?

r=me with these nits picked.

/be
Attachment #438928 - Flags: review?(brendan) → review+
Blocks: 555429
Pushed with nits picked:

http://hg.mozilla.org/tracemonkey/rev/681b0067e61b
Whiteboard: fixed-in-tracemonkey
Backed out:

http://hg.mozilla.org/tracemonkey/rev/5da61a630e98

Weird.  Compiles fine on my Linux box and Mac, but turned the entire tinderbox red.  #include problems.  Maybe I'll fix bug 558723 first.
Turns out I'd only done shell builds, and the failure was in a browser build.

http://hg.mozilla.org/tracemonkey/rev/15da2440d2b0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.