559299 - print preview is broken

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Steffen Wilberg]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.2pre) Gecko/20100317 Lightning/1.0b2pre Lanikai/3.1b2pre (and builds newer than that)

Print Preview is broken. It stops at showing the dialog
  Print Preview
  Title: (loading content for Print Preview)
  Progress: Preparing...

The error console shows:
Error: getNavToolbox is not defined

Source File: chrome://global/content/printUtils.js
Line: 221
which is
    var navToolbox = getNavToolbox();

I can't believe I haven't used print preview since then, but my testing shows:
2010-03-16-03 WORKS
2010-03-17-03 busted
2010-03-17-08 BROKEN

This points to bug 535343.

Comment 1

[Mark Banner (:standard8)]

Can you confirm if this is working on trunk builds (3.2a1pre)?

I'm wondering if the patch in bug 535343 relies on changes in trunk builds, and therefore we need to effectively back it out from 3.1 but keep it for 3.2a1pre...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Uh, bug 535343 was for trunk only.

Where is TB trunk and where is the code to run with 1.9.2?

Comment 3

[Steffen Wilberg]

Yeah, this works with Thunderbird trunk builds (Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a5pre) Gecko/20100413 Shredder/3.2a1pre).

Olli, Thunderbird 3.1pre uses Gecko 1.9.2, but comm-central hasn't branched yet, so you'd have to use #ifndef MOZILLA_1_9_2_BRANCH for code depending on mozilla-central trunk.

Comment 4

[Mark Banner (:standard8)]

As Steffen said, we haven't branched comm-central yet.

However, we are likely to be branching before 3.1b2, and therefore I have the proposal that we leave the code like it is currently, make this bug block beta 2, and then once we've branched we can back out the patch that landed for bug 535343.

Thoughts?

Comment 5

[Mark Banner (:standard8)]

Oh, and with the current tentative plan, that would be just under 2 weeks before we branch.

Comment 6

[Steffen Wilberg]

I can use trunk builds until then as I seemingly didn't notice this for a month...

On the other hand, just three hunks need ifdefs, and the removal would surely be done by a script.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> On the other hand, just three hunks need ifdefs, and the removal would surely
> be done by a script.

Not quite, as you'd also need to pre-process the .js file and remember not to preprocess it later. The other alternative would just be to back out the trunk patch for a while.

I kinda suggested my solution as this obviously isn't used much and it would require the least amount of changes - i.e. one, when we back it out from the branch.

Anyway, I'll leave it open to see what Dan thinks...

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Mark's solution sounds like a reasonable balance of the tradeoffs to me.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Giving to Standard8, since he seems like the most likely person to be doing the backing out post-branching.

Comment 10

[Mark Banner (:standard8)]

Backed out on the 1.9.2 branch only: http://hg.mozilla.org/releases/comm-1.9.2/rev/2b5985cc6e92