Closed Bug 559336 Opened 10 years ago Closed 10 years ago

oggplay_seek_cleanup leaks trash when oggplay_buffer_new_buffer fails

Categories

(Core :: Audio/Video, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file)

79 oggplay_seek_cleanup(OggPlay* me, ogg_int64_t milliseconds)
96   trash = oggplay_calloc(1, sizeof(OggPlaySeekTrash));
104   if (me->buffer != NULL) {
112     me->buffer = oggplay_buffer_new_buffer(me->buffer->buffer_size);
114     if (me->buffer == NULL)
116       return E_OGGPLAY_OUT_OF_MEMORY;
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #438990 - Flags: review?(kinetik)
Attachment #438990 - Attachment is patch: true
Attachment #438990 - Attachment mime type: application/octet-stream → text/plain
We don't use liboggplay on trunk any more (bug 556455 will delete it shortly), but
it might be worth fixing this on the branches.
We've removed liboggplay on trunk. Please reopen this bug if you care about fixing it on branch.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #438990 - Flags: review?(kinetik)
You need to log in before you can comment on or make changes to this bug.