Closed Bug 559413 Opened 10 years ago Closed 10 years ago

getAllLogin call should be replace by findLogins

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(2 files, 1 obsolete file)

This save 20ms on desktop and an average of 45ms for each call on device (with a big gain on first time (more than 100ms).
Attached patch Patch (obsolete) — Splinter Review
Forgot the patch, sorry.
Attachment #439074 - Flags: review?(mark.finkle)
Attached patch PatchSplinter Review
Attachment #439074 - Attachment is obsolete: true
Attachment #439076 - Flags: review?(mark.finkle)
Attachment #439074 - Flags: review?(mark.finkle)
Attachment #439076 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/351d825a6c6f
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Doesn't using findLogins mean you can remove the manual filtering (login.hostname != host.prePath, etc.)?
(In reply to comment #4)
> Doesn't using findLogins mean you can remove the manual filtering
> (login.hostname != host.prePath, etc.)?

Indeed
(In reply to comment #4)
> Doesn't using findLogins mean you can remove the manual filtering
> (login.hostname != host.prePath, etc.)?

you're right!
Why have you leave the mobile team, we missed you!
Attached patch clean upSplinter Review
Thanks for pointing this out.
Attachment #439128 - Flags: review?(gavin.sharp)
Attachment #439128 - Flags: review?(gavin.sharp) → review+
You need to log in before you can comment on or make changes to this bug.