559420 - Cleanup debugger's access to jit/interpreter stack frames

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Edwin Smith]

nativeLocalToAtom() in MethodInfo.cpp is almost identical to makeAtom() in jit-calls.h; the only difference is that it supports loading doubles that aren't 8-byte aligned.  on the platforms where alignment matters, native doubles on the stack will be 8-byte aligned, so its not necessary.  We should remove the code duplication.

We have avmplusDebugger calling methods on MethodInfo, to decode data structures and value encodings that are owned by the JIT and Interpreter, respectively.  At least, the various bits of code should move closer to the modules that own them.  this affects:

class CallStackNode
nativeLocalToAtom() in MethodInfo.cpp
MethodInfo::box/unboxOneLocal()
MethodInfo::box/unboxLocals()

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.