Closed Bug 559501 Opened 10 years ago Closed 8 years ago

On about:support, "Profile Directory" should be "Profile Folder"

Categories

(Toolkit :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla13

People

(Reporter: jruderman, Assigned: aceman)

References

(Blocks 1 open bug)

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

Windows and Mac both use the term "folder" in preference to the term "directory". On Windows, Firefox even uses the term "folder" *right* *there* and it's jarring to see both terms used together.
Assignee: nobody → acelists
Keywords: uiwanted
Assignee: acelists → nobody
Product: Firefox → Toolkit
QA Contact: general → general
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Keywords: polish
Depends on: 559500
Attached patch fix (obsolete) — Splinter Review
Must be applied on top of patch in bug 559500 as it changes neighboring lines.
Attachment #582711 - Flags: review?(benjamin)
Comment on attachment 582711 [details] [diff] [review]
fix

Sorry, doesn't compile.
Attachment #582711 - Attachment is obsolete: true
Attachment #582711 - Flags: review?(benjamin)
Attached patch fix v2 (obsolete) — Splinter Review
Must be applied on top of patch in bug 559500 as it changes neighboring lines.
Attachment #582715 - Flags: review?(benjamin)
Attachment #582715 - Flags: review?(benjamin) → review?(gavin.sharp)
Comment on attachment 582715 [details] [diff] [review]
fix v2

Add an L10N note?
Attachment #582715 - Flags: review?(gavin.sharp) → review+
What should it say?
LOCALIZATION NOTE (aboutSupport.appBasicsProfileDirWinMac): This is the Windows- and Mac-specific variant of aboutSupport.appBasicsProfileDir. Windows/Mac use the term "Folder" instead of "Directory".
Ok, I should finish this.
Carrying over r=gavin.sharp.
Attachment #582715 - Attachment is obsolete: true
Attachment #592730 - Flags: review+
Would be nice if this could make FF12.
I'll file a follow-up for TB.
Keywords: checkin-needed
Blocks: 722355
Whiteboard: [autoland-try]
Whiteboard: [autoland-try] → [autoland-in-queue]
Autoland Patchset:
	Patches: 592730
	Branch: mozilla-central => try
Insufficient permissions to push to try
Whiteboard: [autoland-in-queue]
Comment on attachment 592730 [details] [diff] [review]
fix v3, added note.

(To keep autoland happy)
Attachment #592730 - Flags: review+
Whiteboard: [autoland-try]
Whiteboard: [autoland-try] → [autoland-in-queue]
Autoland Patchset:
	Patches: 592730
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/rev/c467c2875d63
Try run started, revision c467c2875d63. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=c467c2875d63
Try run for c467c2875d63 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=c467c2875d63
Results (out of 206 total builds):
    success: 184
    warnings: 22
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-c467c2875d63
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/mozilla-central/rev/ed55586b0677
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 725971
Status: RESOLVED → VERIFIED
Depends on: 1300562
You need to log in before you can comment on or make changes to this bug.