559677 - "Servers" tab of certificate viewer only displays one item at a time

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Multiple exceptions exist, but only one is displayed. Deleting it displays the next. Shaver and I both saw this in recent Minefields.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Console is flooded with:

Error: this.rows[this.rowMap[aRow]] is undefined
Source File: chrome://pippki/content/certManager.js
Line: 806

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsICertTree.getCellText]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://pippki/content/certManager.js :: getCellText :: line 859"  data: no]

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Only recent-ish change to this UI is http://hg.mozilla.org/mozilla-central/rev/7a3f4933c44f , I think.

Comment 3

[Kai Engert (:KaiE:)]

(In reply to comment #0)
> Multiple exceptions exist, but only one is displayed. Deleting it displays the
> next. Shaver and I both saw this in recent Minefields.

Can't reproduce this.
I had 4 exceptions, all were displayed.
Deleting an exception didn't change the amount of exceptions displayed.


(In reply to comment #1)
> Error: this.rows[this.rowMap[aRow]] is undefined
> Source File: chrome://pippki/content/certManager.js
> Line: 806
> 
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80004005 (NS_ERROR_FAILURE) [nsICertTree.getCellText]"  nsresult: "0x80004005
> (NS_ERROR_FAILURE)"  location: "JS frame ::
> chrome://pippki/content/certManager.js :: getCellText :: line 859"  data: no]


Ouch. Can reproduce this when deleting an exception.

If we can't find a fix soon, we should back out bug 469555.

Comment 4

[Kai Engert (:KaiE:)]

No exceptions after backing out bug 469555 locally.

Comment 5

[Kai Engert (:KaiE:)]

There is another regression caused by the search code which hasn't been addressed yet, either, bug 554009.

I vote to back this out now.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Note that I'm not certain that this was caused by that patch - I wasn't able to reproduce in a new profile, so I couldn't easily bisect. I haven't had a chance to do so with my current profile yet.

Comment 7

[Kai Engert (:KaiE:)]

Attachment: Revert instructions

Comment 8

[Honza Bambas (:mayhemer)]

Comment on attachment 440337 [details] [diff] [review]
Revert instructions

It's a bit mess with the patches in bug 469555.  There is just a single non-obsolete attachment that is just a part of a larger patch.  But go forward.

r=honzab.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Oh wow, I hadn't seen comment 3 and 4 before making comment 6. Weird - not sure how I missed them.

Comment 10

[Kai Engert (:KaiE:)]

I've backed out bug 469555
This should be fixed now.

http://hg.mozilla.org/mozilla-central/rev/3492e15d22b3