"Servers" tab of certificate viewer only displays one item at a time

RESOLVED FIXED

Status

Core Graveyard
Security: UI
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: Gavin, Assigned: timeless)

Tracking

({regression})

Trunk
regression

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(1 attachment)

Multiple exceptions exist, but only one is displayed. Deleting it displays the next. Shaver and I both saw this in recent Minefields.
Console is flooded with:

Error: this.rows[this.rowMap[aRow]] is undefined
Source File: chrome://pippki/content/certManager.js
Line: 806

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsICertTree.getCellText]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://pippki/content/certManager.js :: getCellText :: line 859"  data: no]
Only recent-ish change to this UI is http://hg.mozilla.org/mozilla-central/rev/7a3f4933c44f , I think.
blocking2.0: --- → ?

Updated

8 years ago
Assignee: kaie → timeless
Keywords: regression

Comment 3

8 years ago
(In reply to comment #0)
> Multiple exceptions exist, but only one is displayed. Deleting it displays the
> next. Shaver and I both saw this in recent Minefields.

Can't reproduce this.
I had 4 exceptions, all were displayed.
Deleting an exception didn't change the amount of exceptions displayed.


(In reply to comment #1)
> Error: this.rows[this.rowMap[aRow]] is undefined
> Source File: chrome://pippki/content/certManager.js
> Line: 806
> 
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80004005 (NS_ERROR_FAILURE) [nsICertTree.getCellText]"  nsresult: "0x80004005
> (NS_ERROR_FAILURE)"  location: "JS frame ::
> chrome://pippki/content/certManager.js :: getCellText :: line 859"  data: no]


Ouch. Can reproduce this when deleting an exception.

If we can't find a fix soon, we should back out bug 469555.

Comment 4

8 years ago
No exceptions after backing out bug 469555 locally.

Comment 5

8 years ago
There is another regression caused by the search code which hasn't been addressed yet, either, bug 554009.

I vote to back this out now.
Note that I'm not certain that this was caused by that patch - I wasn't able to reproduce in a new profile, so I couldn't easily bisect. I haven't had a chance to do so with my current profile yet.

Comment 7

8 years ago
Created attachment 440337 [details] [diff] [review]
Revert instructions
Attachment #440337 - Flags: review?(honzab.moz)
Comment on attachment 440337 [details] [diff] [review]
Revert instructions

It's a bit mess with the patches in bug 469555.  There is just a single non-obsolete attachment that is just a part of a larger patch.  But go forward.

r=honzab.
Attachment #440337 - Flags: review?(honzab.moz) → review+
Oh wow, I hadn't seen comment 3 and 4 before making comment 6. Weird - not sure how I missed them.

Comment 10

8 years ago
I've backed out bug 469555
This should be fixed now.

http://hg.mozilla.org/mozilla-central/rev/3492e15d22b3
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
blocking2.0: ? → final+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.