559688 - [bt] Need a "browse.search-providers" link in the browse app

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

https://preview.addons.mozilla.org/z/en-US/firefox/addon/54905/

Traceback (most recent call last):

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/handlers/base.py", line 101, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/addons/views.py", line 28, in decorated
   return f(request, *args, **kwargs)

 File "/data/amo_python/www/preview/zamboni/apps/addons/views.py", line 41, in addon_detail
   return extension_detail(request, addon)

 File "/data/amo_python/www/preview/zamboni/apps/addons/views.py", line 110, in extension_detail
   return jingo.render(request, 'addons/details.html', data)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jingo/__init__.py", line 61, in render
   rendered = render_to_string(request, template, context)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jingo/__init__.py", line 80, in render_to_string
   ret = template.render(**context)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/jinja2/environment.py", line 705, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/details.html", line 1, in top-level template code
   {% extends "base.html" %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 60, in top-level template code
   {% block main_content %}

 File "/data/amo_python/www/preview/zamboni/templates/base.html", line 67, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/amo_python/www/preview/zamboni/apps/addons/templates/addons/details.html", line 275, in block "content"
   <a href="{{ category.get_url_path() }}" class="more-info">

 File "/data/amo_python/www/preview/zamboni/apps/addons/models.py", line 576, in get_url_path
   return reverse('browse.%s' % type, args=[self.slug])

 File "/data/amo_python/www/preview/zamboni/apps/amo/urlresolvers.py", line 44, in reverse
   url = django_reverse(viewname, urlconf, args, kwargs, prefix, current_app)

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/urlresolvers.py", line 356, in reverse
   *args, **kwargs)))

 File "/data/virtualenvs_preview/zamboni/lib/python2.6/site-packages/django/core/urlresolvers.py", line 302, in reverse
   "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'browse.search-providers' with arguments '(u'dictionaries-encyclopedias',)' and keyword arguments '{}' not found.

Comment 1

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)
> NoReverseMatch: Reverse for 'browse.search-providers' with arguments
> '(u'dictionaries-encyclopedias',)' and keyword arguments '{}' not found.

It needs a view matching browse.search-providers.  We'll have to make sure all the add-on types have a corresponding browse page for that pattern to work.

Comment 3

[Fred Wenzel [:wenzel]]

Apparently this makes details pages fail, too. I'll add a dummy view for now.

Comment 4

[Fred Wenzel [:wenzel]]

Landed: http://github.com/jbalogh/zamboni/commit/99ed5d4539cbf69e6915ce3e1a50aee7e7394833

... and fixed.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I can load https://preview.addons.mozilla.org/z/en-US/firefox/addon/54905/ and https://preview.addons.mozilla.org/z/en-US/firefox/addon/86341/ (from duplicate bug 559867) just fine.