Closed Bug 559691 Opened 10 years ago Closed 10 years ago

Don't use viewport metadata scale if it is less than screen width

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

()

Details

Attachments

(1 file)

Attached patch patchSplinter Review
http://daringfireball.net sets its viewport to "width=600, initial-scale=0.5, minimum-scale=0.45".  Fennec always zooms the site to 0.5 (300px wide) by default, leaving an empty space at the edge of the window.

This patch uses "page zoom" (fit to width) as a minimum default zoom level.  This matches the behavior of both Android Browser and Mobile Safari, and is also more consistent with the new zoomout button limit (bug 556617).
Attachment #439393 - Flags: review?(mark.finkle)
Attachment #439393 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/79f4ae007145
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
On both 1.9.2 and trunk builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100419 Namoroka/3.6.5pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a5pre) Gecko/20100419 Namoroka/3.7a5pre Fennec/1.1a2pre

I'm seeing a gray bar on the right side of the page.
(In reply to comment #2)

> I'm seeing a gray bar on the right side of the page.

I think this is because of an interaction with the "fuzzy" zoom-to-page
(In reply to comment #3)
> I think this is because of an interaction with the "fuzzy" zoom-to-page

Yes, the one remaining place where we intentionally show a gray bar is when fuzzy page fit rounds the zoom level down from 1.1 (or less) to 1.0.

If the gray bar is shown and the zoom level is not 1.0, then I think that's a bug.
Filed the fuzzy page fit issue as bug 560275.
Thanks for the bug filing, Matt!

verified FIXED with follow-up bug in comment #5 on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100419 Namoroka/3.6.5pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a5pre) Gecko/20100419 Namoroka/3.7a5pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.