559695 - warning C4700: uninitialized local variable 'rv' used in nsStorageFormHistory.cpp

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

toolkit\components\satchel\src\nsstorageformhistory.cpp(1141) : warning C4700: uninitialized local variable 'rv' used
toolkit\components\satchel\src\nsstorageformhistory.cpp(1080) : warning C4700: uninitialized local variable 'rv' used

This code was added by bug 487556.
http://hg.mozilla.org/mozilla-central/rev/aa8d539cf6e1

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/file/default/toolkit/components/satchel/src/nsStorageFormHistory.cpp#l1080

http://hg.mozilla.org/mozilla-central/file/default/toolkit/components/satchel/src/nsStorageFormHistory.cpp#l1141

Both should probably just return NS_ERROR_OUT_OF_MEMORY; ?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Yeah. Could also use the two-arg version of do_CreateInstance, but given the callers before that don't, and the unlikelihood of failure, better to just hard code the return value there and move down "rv"'s declaration - r=me!

Comment 3

[Ed Lee :Mardak]

Attachment: v1

I moved the nsresult rv to also be assigned on the same line.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 439467 [details] [diff] [review]
v1

I think maybe you didn't intend to request feedback from yourself? You can have an r=me :)

(wouldn't hurt to make the same declaration-moving change to the other nsFormHistory::SendNotification, too)

Comment 5

[Ed Lee :Mardak]

Attachment: v1.1

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/7192f4dba530