559696 - Make sure Tamarin compiles and runs ok on GCC 4.5.0

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

Just released

http://gcc.gnu.org/gcc-4.5/changes.html.

This will be a tracker for any issues, or optimistically, will be closed soon as WORKSFORME.

Comment 1

[Lars T Hansen]

Might want to check out gcc 4.4 too - didn't work last time I tried.  (Comes standard with Ubuntu 9.10 I think.)

Comment 2

[Edwin Smith]

good to know.  i build with gcc 4.4 on ubuntu-64 9.10 fairly often, but that's just a data point.  haven't tried x86-32.

Comment 3

[Dan Smith]

Investigating runtime compiler requirements for 2011-2012.

Comment 4

[Dan Smith]

Rather, Flash Runtime's compiler requirements for 2011-2012..

Comment 5

[Edwin Smith]

By the way, gcc 4.6.x is available now and there's at least one bug on tamarin with it.

Comment 6

[James Marshall]

I found a few compiling bugs having to do with setting a non-pointer to NULL; the pthread_t and uint32_t types were the culprits.  The bugs were at:

eval/eval-cogen.cpp line 312
extensions/SelftestExec.cpp line 2273
MMgc/GC.cpp line 3770
MMgc/PageMap.cpp line 433

I believe I also had to manually install utils/asc.jar .

I'm using Linux 2.6.34 64-bit (openSUSE) and gcc 4.5.0 .

Comment 7

[Lars T Hansen]

I fixed the bits in eval-cogen.cpp and PageMap.cpp (for starters).

Comment 8

[Lars T Hansen]

Also the one in SelftestExec.cpp.

Comment 9

[Tamarin Bot]

changeset: 6757:66ce845cc327
user:      Lars T Hansen <[e-mail]>
summary:   For 559696: Fixed another NULL/0 confusion (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/66ce845cc327

Comment 10

[Felix S. Klock II [:pnkfelix, :fklock]]

Incidentally, we seem to have some problems on GCC 4.6.x (i.e. the successor to 4.5, which is the subject of this ticket) for x <= 2, due to a GCC bug with our offsetof usage:

../core/CodegenLIR.cpp:3735:108: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3739:108: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3743:105: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3747:106: error: cannot apply ‘offsetof’ to a non constant address
[etc...]

This is due to the following GCC bug:

  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50608

So until a working version of GCC 4.6 is deployed, we should target 4.5 and below.

Comment 11

[Trevor Baker]

gcc bug Bug 50608 has been fixed for 4.6

Do we still have problems on 4.5?

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.