Closed Bug 559696 Opened 14 years ago Closed 6 years ago

Make sure Tamarin compiles and runs ok on GCC 4.5.0

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

Just released

http://gcc.gnu.org/gcc-4.5/changes.html.

This will be a tracker for any issues, or optimistically, will be closed soon as WORKSFORME.
Target Milestone: --- → Future
Might want to check out gcc 4.4 too - didn't work last time I tried.  (Comes standard with Ubuntu 9.10 I think.)
good to know.  i build with gcc 4.4 on ubuntu-64 9.10 fairly often, but that's just a data point.  haven't tried x86-32.
Depends on: 556312
Flags: flashplayer-qrb+
Whiteboard: loose-end
Flags: flashplayer-qrb+ → flashplayer-qrb?
Whiteboard: loose-end
Investigating runtime compiler requirements for 2011-2012.
Rather, Flash Runtime's compiler requirements for 2011-2012..
By the way, gcc 4.6.x is available now and there's at least one bug on tamarin with it.
Depends on: 648249, 664143, 656008
I found a few compiling bugs having to do with setting a non-pointer to NULL; the pthread_t and uint32_t types were the culprits.  The bugs were at:

eval/eval-cogen.cpp line 312
extensions/SelftestExec.cpp line 2273
MMgc/GC.cpp line 3770
MMgc/PageMap.cpp line 433

I believe I also had to manually install utils/asc.jar .

I'm using Linux 2.6.34 64-bit (openSUSE) and gcc 4.5.0 .
I fixed the bits in eval-cogen.cpp and PageMap.cpp (for starters).
Also the one in SelftestExec.cpp.
changeset: 6757:66ce845cc327
user:      Lars T Hansen <lhansen@adobe.com>
summary:   For 559696: Fixed another NULL/0 confusion (r=lhansen)

http://hg.mozilla.org/tamarin-redux/rev/66ce845cc327
Incidentally, we seem to have some problems on GCC 4.6.x (i.e. the successor to 4.5, which is the subject of this ticket) for x <= 2, due to a GCC bug with our offsetof usage:

../core/CodegenLIR.cpp:3735:108: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3739:108: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3743:105: error: cannot apply ‘offsetof’ to a non constant address
../core/CodegenLIR.cpp:3747:106: error: cannot apply ‘offsetof’ to a non constant address
[etc...]

This is due to the following GCC bug:

  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50608

So until a working version of GCC 4.6 is deployed, we should target 4.5 and below.
gcc bug Bug 50608 has been fixed for 4.6

Do we still have problems on 4.5?
Tamarin is a dead project now. Mass WONTFIX.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Tamarin isn't maintained anymore. WONTFIX remaining bugs.
You need to log in before you can comment on or make changes to this bug.