559731 - The add-on detail page is INVALID!!!

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect, P4)

Description

[Jeff Balogh (:jbalogh)]

Not the precision german engineering that I was expecting.

   1.

      Error: No element a to close.

      From line 325, column 7; to line 325, column 10

      /a>↩ </a>↩↩
   2.

      Error: Any input descendant of a label element with a for attribute must have an ID value that matches that for attribute.

      From line 361, column 65; to line 361, column 115

      tion of $ <input type="text" name="monthly-amount" value=""/>↩
   3.

      Warning: The summary attribute is obsolete. Consider describing the structure of complex tables in <caption> or in a paragraph and pointing to the paragraph using the aria-describedby attribute.

      From line 387, column 11; to line 387, column 46

      <table summary="Add-on Information">↩
   4.

      Error: Bad value 2010-02-21 22:03:32+0000 for attribute datetime on element time: The literal did not satisfy the date format.

      From line 392, column 19; to line 392, column 60

      <time datetime="2010-02-21 22:03:32+0000">Februa

      Syntax of date or time:
          (This format deviates from the spec draft.) An ISO 8601 date (i.e. YYYY-MM-DD.), time (i.e. hh:mm optionally followed by :ss optionally followed by . and digits) optionally with a time zone designator (i.e. either Z, +hh:mm or -hh:mm) or both date and time separated by T. Examples: 1996-01-01T12:05:25, 1996-01-01, 12:05:25, 1996-01-01T12:05:25.6-02:00 

   5.

      Error: Bad value for attribute target on element a: Browsing context name must be at least one character long.

      From line 497, column 15; to line 497, column 64

      <a class="uniquify" target="" href="/users/login">↩

      Syntax of browsing context name or keyword:
          A browsing context name or keyword is either any string that does not start with an underscore (_) or a string that case-insensitively matches one of: _blank, _self, _parent, or _top. 

   6.

      Error: End tag for p seen, but there were unclosed elements.

      From line 621, column 89; to line 621, column 92

      ersion 3.0</p>↩ ↩
   7.

      Error: An a start tag seen with already an active a element.

      From line 625, column 21; to line 625, column 52

      <a href="/addons/versions/2108">↩
   8.

      Error: End tag a violates nesting rules.

      From line 625, column 21; to line 625, column 52

      <a href="/addons/versions/2108">↩
   9.

      Fatal Error: Cannot recover after last error. Any further errors will be ignored.

      From line 625, column 21; to line 625, column 52

      <a href="/addons/versions/2108">↩

Comment 1

[Fred Wenzel [:wenzel]]

Excuse me, are you making fun of invalids?

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> Not the precision german engineering that I was expecting.
> 
>    1.
> 
>       Error: No element a to close.
> 
>       From line 325, column 7; to line 325, column 10
> 
>       /a>↩ </a>↩↩

That's button code -- and the error does not show up anymore.

>    2.
> 
>       Error: Any input descendant of a label element with a for attribute must
> have an ID value that matches that for attribute.
> 
>       From line 361, column 65; to line 361, column 115
> 
>       tion of $ <input type="text" name="monthly-amount" value=""/>↩

Hm. The input is wrapped in the label, but the label itself refers to a radio button. We could change that, but I don't see much of a reason atm, considering the L10n impact.

>    3.
> 
>       Warning: The summary attribute is obsolete. Consider describing the
> structure of complex tables in <caption> or in a paragraph and pointing to the
> paragraph using the aria-describedby attribute.
> 
>       From line 387, column 11; to line 387, column 46
> 
>       <table summary="Add-on Information">↩

I contacted Marco on this.

>    4.
> 
>       Error: Bad value 2010-02-21 22:03:32+0000 for attribute datetime on
> element time: The literal did not satisfy the date format.
> 
>       From line 392, column 19; to line 392, column 60
> 
>       <time datetime="2010-02-21 22:03:32+0000">Februa
> 
>       Syntax of date or time:
>           (This format deviates from the spec draft.) An ISO 8601 date (i.e.
> YYYY-MM-DD.), time (i.e. hh:mm optionally followed by :ss optionally followed
> by . and digits) optionally with a time zone designator (i.e. either Z, +hh:mm
> or -hh:mm) or both date and time separated by T. Examples: 1996-01-01T12:05:25,
> 1996-01-01, 12:05:25, 1996-01-01T12:05:25.6-02:00 
> 

I have a patch for this, making it: 1996-01-01T12:05:25.6Z

CCing davedash, if I change the isotime helper to this, will the API be fine? You use the helper over there. FWIW, both the variant we are using and the one I am citing here are ISO8601, but only this one is supported by HTML5.

>    5.
> 
>       Error: Bad value for attribute target on element a: Browsing context name
> must be at least one character long.
> 
>       From line 497, column 15; to line 497, column 64
> 
>       <a class="uniquify" target="" href="/users/login">↩
> 
>       Syntax of browsing context name or keyword:
>           A browsing context name or keyword is either any string that does not
> start with an underscore (_) or a string that case-insensitively matches one
> of: _blank, _self, _parent, or _top. 
> 

http://github.com/jbalogh/zamboni/commit/3c3a476f6e6b54422c7d61e5e5ba195718fd08d9

>    6.
> 
>       Error: End tag for p seen, but there were unclosed elements.
> 
>       From line 621, column 89; to line 621, column 92
> 
>       ersion 3.0</p>↩ ↩
>    7.
> 
>       Error: An a start tag seen with already an active a element.
> 
>       From line 625, column 21; to line 625, column 52
> 
>       <a href="/addons/versions/2108">↩
>    8.
> 
>       Error: End tag a violates nesting rules.
> 
>       From line 625, column 21; to line 625, column 52
> 
>       <a href="/addons/versions/2108">↩
>    9.
> 
>       Fatal Error: Cannot recover after last error. Any further errors will be
> ignored.
> 
>       From line 625, column 21; to line 625, column 52
> 
>       <a href="/addons/versions/2108">↩

http://github.com/jbalogh/zamboni/commit/98609542f1447e2b3ef88e38905c5ed747b4fde0

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Fred,

Changing the format should be alright, since there are new to 1.5API

Comment 4

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> >       Warning: The summary attribute is obsolete. Consider describing the
> > structure of complex tables in <caption> or in a paragraph and pointing to the
> > paragraph using the aria-describedby attribute.
> > 
> >       From line 387, column 11; to line 387, column 46
> > 
> >       <table summary="Add-on Information">↩
> 
> I contacted Marco on this.

Marco prefers caption with CSS magic, so I implemented it: http://github.com/jbalogh/zamboni/commit/037b2d469e51e3f665690078938a05d6511881de

> >    4.
> > 
> >       Error: Bad value 2010-02-21 22:03:32+0000 for attribute datetime on
> > element time: The literal did not satisfy the date format.
> > 
> >       From line 392, column 19; to line 392, column 60
> > 
> >       <time datetime="2010-02-21 22:03:32+0000">Februa
> > 
> >       Syntax of date or time:
> >           (This format deviates from the spec draft.) An ISO 8601 date (i.e.
> > YYYY-MM-DD.), time (i.e. hh:mm optionally followed by :ss optionally followed
> > by . and digits) optionally with a time zone designator (i.e. either Z, +hh:mm
> > or -hh:mm) or both date and time separated by T. Examples: 1996-01-01T12:05:25,
> > 1996-01-01, 12:05:25, 1996-01-01T12:05:25.6-02:00 
> > 
> 
> I have a patch for this, making it: 1996-01-01T12:05:25.6Z

http://github.com/jbalogh/zamboni/commit/8821af1f681940652376430f855054a0906c0d8f

This should be done. Will look how the validator behaves now and close this if it's silent.

Comment 6

[Fred Wenzel [:wenzel]]

This is fixed for the most part. The label is comment 2 no. 2, where I don't see the benefit out weighing the cost at the moment. The other one (role=secondary) is weird -- apparently such an ARIA role does not exist. I could just remove it, I guess?

Comment 7

[Fred Wenzel [:wenzel]]

The ARIA role is fixed.

http://github.com/jbalogh/zamboni/commit/dea7192b63d9012f4a676d7bdee5b305ca25e6a9

Calling this fixed, minus comment 6.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.