559739 - Incorrect Message display when no login provided

Status: NEW

(Websites :: creative.mozilla.org, defect)

Description

[Ayan Shah[:ashah]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.9) Gecko/20100315 Firefox/3.5.9 (.NET CLR 3.5.30729)

In the creative.mozilla.org, I went on the login page and clicked login without supplying any username and password. It gave me a message that the " Login credentials supplies does not match a verified account. Please try again". This is a bug because I havent supplied any login credentials. It should display that please provide a username and password. In short, it should do client side validation instead of going on the server side.

Reproducible: Always

Steps to Reproduce:
1.Go to https://creative.mozilla.org/login
2. Without entering any username and password, press Login
3. It displays the message - "Login credentials supplies does not match a verified account. Please try again". 
Actual Results:  
It displays the message - "Login credentials supplies does not match a verified account. Please try again"

Expected Results:  
It should have done client side validation and said that please enter the missing fields - username and password

Comment 1

[Boris Zbarsky [:bzbarsky]]

There's no client-side validation going on here.  The validation is purely server-side, and the text you see is just whatever the server is deciding to send back.  Not a DOM issue, for sure.

Comment 2

[Ayan Shah[:ashah]]

Ok. It might not be a DOM but a javascript thing to do. 
But take it as a suggestion. Thats because it is more appropriate to check for empty fields on the client side itself rather than making a trip to server. 
Also the message displayed is not helping the user.
And I have checked with the Krupa(QA at Mozilla) and she has agreed that its a bug.

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's not a DOM or a javascript thing but a website authoring thing.  As in, not a bug in the Gecko rendering engine (which is where you filed the bug)...

Comment 4

[krupa raj[:krupa]]

Ayan,

Thanks for proactively filing the bug you discussed with me.

The user message here is indeed confusing.With login forms,the usual order of error checking is-

1)check for missing data in required fields
2)mismatch between password and confirm password fields
3)invalid characters/keywords
4)user account does not exist

So in the case mentioned in comment#0,a more useful and appropriate error message would be-"Username and Password fields are required for Login"

That said,going forward.. please file all website related bugs at https://bugzilla.mozilla.org/enter_bug.cgi?product=Websites

Thanks!