Build: 2000-10-10-09-MN6(WIN), 2000-10-10-10-MN6(MAC), 2000-10-10-10-MN6(LINUX) 1. From http://jimbob/trigger3.html, click Functional drop-down and choose f_alertconfirm 2. Click Trigger case button 3. Click OK button from XPInstall confirm dialog 4. Click OK/Cancel button as alert and confirm dialogs appear RESULT: This broke on 10/4/00. Before this date, no text appeared from the title bar on alert/confirm dialogs. From Windows NT, garbage characters appear on the title bar. From Linux, "mozilla-bin" appears as the titlebar text instead of "alert" and "confirm", respectively. From Mac, no text appears instead of "alert" and "confirm", respectively. I am using http://jimbob/bugs/confirm_it.html to compare behavior of alert/confirm dialog. Dialogs appear correct when called from this html page. EXPECTED RESULT: "alert" and "confirm" are the title bar text for these types of dialogs when called from xpi packages.
Windows 98 also shows garbage characters as the titlebar text for alert/confirm dialogs.
Over to mister dialog man
Moz 0.9 tasks
We used to be able to pass nsnull as the title and basically have no title. This is no longer the case. The fix is to either pass a title which would require a change to the nsInstall::Alert and nsInstall::Confirm and their related nsJSInstall apis or to just translate the words "Alert" and "Confirm" for the titles. I've decided to do the latter and will post the diff.
Created attachment 26044 [details] [diff] [review] Patch of nsInstall.cpp. nsInstall::Alert and ::Confirm changed
Fix checked in. We now get the words Alert and Confirm on the title bar. (These should up in the correct language)
Build: 2001-03-01-11-Mtrunk(WIN), 2001-03-01-09-trunk(MAC), 2001-03-01-08-Mtrunk(LINUX) Looking good! Marking Verified!