alert/confirm dialogs from xpi display bad text on title bar

VERIFIED FIXED in mozilla0.9

Status

Core Graveyard
Installer: XPInstall Engine
P4
trivial
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: Jimmy Lee, Assigned: dbragg)

Tracking

Trunk
mozilla0.9

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [xpibug])

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Build: 2000-10-10-09-MN6(WIN), 2000-10-10-10-MN6(MAC), 2000-10-10-10-MN6(LINUX)

1. From http://jimbob/trigger3.html, click Functional drop-down and choose
   f_alertconfirm
2. Click Trigger case button
3. Click OK button from XPInstall confirm dialog
4. Click OK/Cancel button as alert and confirm dialogs appear

RESULT:
This broke on 10/4/00.  Before this date, no text appeared from the title bar on 
alert/confirm dialogs.

From Windows NT, garbage characters appear on the title bar.  From Linux, 
"mozilla-bin" appears as the titlebar text instead of "alert" and "confirm", 
respectively.  From Mac, no text appears instead of "alert" and "confirm", 
respectively.

I am using http://jimbob/bugs/confirm_it.html to compare behavior of 
alert/confirm dialog.  Dialogs appear correct when called from this html page.

EXPECTED RESULT:
"alert" and "confirm" are the title bar text for these types of dialogs when 
called from xpi packages.
(Reporter)

Comment 1

17 years ago
Windows 98 also shows garbage characters as the titlebar text for alert/confirm 
dialogs.
Over to mister dialog man
Assignee: dveditz → dbragg
Keywords: nsbeta1
Whiteboard: [xpibug]
Moz 0.9 tasks
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 4

17 years ago
p4 tasks
Priority: P3 → P4

Updated

17 years ago
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Comment 5

17 years ago
We used to be able to pass nsnull as the title and basically have no title.
This is no longer the case.  The fix is to either pass a title which would
require a change to the nsInstall::Alert and nsInstall::Confirm and their
related nsJSInstall apis or to just translate the words "Alert" and "Confirm"
for the titles.  I've decided to do the latter and will post the diff.
(Assignee)

Comment 6

17 years ago
Created attachment 26044 [details] [diff] [review]
Patch of nsInstall.cpp.  nsInstall::Alert and ::Confirm changed

Comment 7

17 years ago
r=sgehani

Comment 8

17 years ago
sr=mscott
(Assignee)

Comment 9

17 years ago
Fix checked in.  We now get the words Alert and Confirm on the title bar.
(These should up in the correct language)
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

17 years ago
Build: 2001-03-01-11-Mtrunk(WIN), 2001-03-01-09-trunk(MAC), 
2001-03-01-08-Mtrunk(LINUX)

Looking good!  Marking Verified!
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.