559839 - Failures in ajax test suites aren't counted

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, major)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch 1: Use the normal test harness

These failures aren't counted because the ajax tests use their own copy of the test files. Patch attached to make them use the normal ones.

For an example of failures that were missed, see bug 558610.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch 2: Remove the unused copies

And for good measure, remove the copies of the test harness.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks.

Comment 3

[Phil Ringnalda (:philor)]

Probably best not to check this in until bug 561700 is fixed, since it's going to suddenly make every single M2 (justifiably, correctly) orange.

Comment 4

[Phil Ringnalda (:philor)]

Where by "is fixed" I mean "or the cause is backed out, which it is now, so assuming these patches make it through the tryserver run that's going right now, oh, pretty pretty please someone check this bad boy in."

Comment 5

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-central/rev/ea7e3f4f45d7
http://hg.mozilla.org/mozilla-central/rev/d06dc7394b02

Comment 6

[Serge Gautherie (:sgautherie)]

Thanks, I assume the removals are welcome.
But I would (have) preferred that you use stubs in the tests, as in bug 427500 patch Gv1a...

Comment 8

[Joel Maher ( :jmaher ) (UTC-4) (on leave, back November 5th)]

there is still a copy of SimpleTest.js and TestRunner.js in the ajax source on mozilla-central:
http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/