Closed
Bug 559839
Opened 13 years ago
Closed 13 years ago
Failures in ajax test suites aren't counted
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(2 files)
3.29 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
167.98 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
These failures aren't counted because the ajax tests use their own copy of the test files. Patch attached to make them use the normal ones. For an example of failures that were missed, see bug 558610.
Attachment #439538 -
Flags: review?(sayrer)
Assignee | ||
Comment 1•13 years ago
|
||
And for good measure, remove the copies of the test harness.
Attachment #439539 -
Flags: review?(sayrer)
Updated•13 years ago
|
Attachment #439538 -
Flags: review?(sayrer) → review+
Updated•13 years ago
|
Attachment #439539 -
Flags: review?(sayrer) → review+
Comment 3•13 years ago
|
||
Probably best not to check this in until bug 561700 is fixed, since it's going to suddenly make every single M2 (justifiably, correctly) orange.
Comment 4•13 years ago
|
||
Where by "is fixed" I mean "or the cause is backed out, which it is now, so assuming these patches make it through the tryserver run that's going right now, oh, pretty pretty please someone check this bad boy in."
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ea7e3f4f45d7 http://hg.mozilla.org/mozilla-central/rev/d06dc7394b02
Comment 6•13 years ago
|
||
Thanks, I assume the removals are welcome. But I would (have) preferred that you use stubs in the tests, as in bug 427500 patch Gv1a...
Comment 8•13 years ago
|
||
there is still a copy of SimpleTest.js and TestRunner.js in the ajax source on mozilla-central: http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•