559845 - Form-helper close button (red X) looks like a cancel button

Status: VERIFIED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

The appearance of the form-helper close button is confusing.  From Milos on #testday:

> Milos: adobe's flash download page, choose os
> Milos: it has no button to accept what you chose, there's just
>   cancel-like button, red rounded one with white X in it

Maybe we should replace the red X with a "Done" button or a down arrow - something that clearly means "hide" instead of "cancel."

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We used to have a Done button, iirc. We changed it to an image. The close image is the same we use in tabs to "close" a tab. We had hoped consistent use of the image would make it more understandable.

Comment 2

[Milos Dinic [:Milos]]

I'm afraid we got just the opposite effect of that image then we expected. At a first look, I'd (and I actually did) say that clicking on that image will cancel whatever I'm doing in the focused section of the page. It of course was logical that clicking on that button will close the form-helper, but I also thought that it would forget whatever I did before.

Comment 3

[Matt Brubeck (:mbrubeck)]

The new form helper design (Bug 580213) has no close button.

Comment 4

[Aakash Desai [:aakashd]]

verified invalid on build:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b4pre) Gecko/20100811 Namoroka/4.0b4pre Fennec/2.0a1pre