Run build-tools tests on checkin

RESOLVED FIXED

Status

Release Engineering
General
P4
normal
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: catlee, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [automation][q2goal])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
We have some tests in build-tools for clobberer and for signing.

These should be run whenever build-tools is changed.

Comment 1

8 years ago
Marking as P4 since this is a Q2 goal for releng.
Priority: -- → P4
(Assignee)

Updated

7 years ago
Assignee: nobody → rail
(Assignee)

Comment 2

7 years ago
Created attachment 493653 [details] [diff] [review]
clobberer params

test_clobberer.py hardcodes some of the variables needed for testing. Attached patch accepts 2 parameters which override these variables and removes them from sys.argv to make unittest.main() happy.
Attachment #493653 - Flags: review?(catlee)
(Reporter)

Comment 3

7 years ago
Comment on attachment 493653 [details] [diff] [review]
clobberer params

Please add some comments and maybe some cmdline help for these arguments.
Attachment #493653 - Flags: review?(catlee) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 493653 [details] [diff] [review]
clobberer params

http://hg.mozilla.org/build/tools/rev/27b1b0f690b4
Attachment #493653 - Flags: checked-in+
(Assignee)

Comment 5

7 years ago
I've enabled tests for tools/lib/python, tools/cloberrer and tools/release/signing in preproduction. The first one passes, the second and third don't.

I've set flunkOnFailure=False for 2 and 3 for now and filed followup bugs: bug 616161 and bug 616162.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.