559890 - Run build-tools tests on checkin

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P4)

Description

[Chris AtLee [:catlee]]

We have some tests in build-tools for clobberer and for signing.

These should be run whenever build-tools is changed.

Comment 1

[Chris Cooper [:coop] (he/him)]

Marking as P4 since this is a Q2 goal for releng.

Comment 2

[Rail Aliiev [:rail]]

Attachment: clobberer params

test_clobberer.py hardcodes some of the variables needed for testing. Attached patch accepts 2 parameters which override these variables and removes them from sys.argv to make unittest.main() happy.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 493653 [details] [diff] [review]
clobberer params

Please add some comments and maybe some cmdline help for these arguments.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 493653 [details] [diff] [review]
clobberer params

http://hg.mozilla.org/build/tools/rev/27b1b0f690b4

Comment 5

[Rail Aliiev [:rail]]

I've enabled tests for tools/lib/python, tools/cloberrer and tools/release/signing in preproduction. The first one passes, the second and third don't.

I've set flunkOnFailure=False for 2 and 3 for now and filed followup bugs: bug 616161 and bug 616162.