559909 - Fix iteratorUtils.toArray's NodeList and Iterator checks

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Blake Winton (:bwinton) (:☕️)]

(Yeah, I know, this totally isn't the right place for this bug, but it seemed like the closest thing I could find.)

I would like to use the toArray function from mail/base/content/featureConfigurator.js, but NodeList doesn't seem to exist, so it fails with an exception.

I tried changing it to Ci.nsIDOMNodeList, but that didn't really help me, because it still returned null for the iterator I passed in.

I start with an [xpconnect wrapped nsISupportsArray @ 0x1b4e3530 (native @ 0x1b4e34f0)], pass that to fixIterator, which seems to return me "return { __iterator__: iter };" from line 116 in mailnews/base/util/iteratorUtils.jsm).  But, since that doesn't have Iterator.prototype in its prototype chain, the call to "aObj instanceof Iterator" on line 62 fails, and I get null back.

At least, I think that's what's happening.

Thanks,
Blake.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch + tests

Right, this fixes things. I had to add a hack similar to the one I removed in bug 603192. Oh well, you win some, you lose some.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 482150 [details] [diff] [review]
patch + tests

a most excellent and thorough test; thank you!

Comment 3

[Rain [:rain1] (inactive)]

I'll open a separate bug to fix featureConfigurator.js.

Comment 4

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/6d7a363afbb9

(I added a couple of extra sanity checks to the test)