55991 - Right clicking in a cell doesn't set selection correctly

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 10/10 build of netscape

1) launch netscape
2) launch composer
3) enter 5 x 5 table
4) click in a cell
5) right mouse click to bring up context menu
6) select Join Cell option

notice it doesn't join cell....maybe its not redrawing...

Join cell does work from Table menu.

Comment 1

[Simon Fraser [no longer active]]

cmanske, future.

Comment 2

[Kristi Fredrickson]

Should this be release noted for RTM, or is it too minor a bug to document?

If the verdict is to add this to release notes, what's the recommended 
workaround?

Comment 3

[Kathleen :Brade]

nominate this bug to be fixed before mozilla 1.0; we should either fix this
context menu item to work or remove it from the context menu.

Comment 4

[Charles Manske]

Original bug claimed 'Join cells' didn't work. That's not the problem. The
problem is that when you right-click on an empty cell, the selection is lost,
thus "Join cells" (or many other table commands) don't work. What should happen:
The caret (collapsed selection) should be set to the beginning of the cell
contents before the popup menu appears.

Comment 5

[Charles Manske]

Attachment: Fix for bug.

Comment 6

[Charles Manske]

Problem was that when right clicking in an empty cell, the mouse event "target"
element is the cell itself instead of the usual textnode or other content of cell.
We were selecting the cell in that case when we really just want to put caret
(collapse the selection) into that cell.

Comment 7

[Charles Manske]

Selection is collapsed to beginning of cell right-clicked in.

Comment 8

[Kristi Fredrickson]

Replacing kristif with robinf. Robin Foster is now the doc contact for Composer

Comment 9

[Charles Manske]

checked in

Comment 10

[Kathleen :Brade]

reopening bug; this does not work if the cell is empty (has no text or only br's)

Comment 11

[Charles Manske]

It doesn't seem to work period, even with cell contents. Must have regressed
because of other changes in that code.

Comment 12

[Charles Manske]

Attachment: Fixed testing if mouse click is in selection.

Comment 13

[Charles Manske]

The problem was in the loop which tests if the point clicked on is within the
selection range(s). Once a range is found, we must exit loop. When there are
multiple cells selected, we were erroneously concluding that we weren't clicking
in the selection.

Comment 14

[kinmoz]

sr=[e-mail]

Comment 15

[Akkana Peck]

r=akkana

Comment 16

[Charles Manske]

checked in.

Comment 17

[sujay]

still not working using 6/4 build.

Comment 18

[kmurray1115]

I don't consider this a 9.1 stopper - can we move this to 9.2?

Comment 19

[Charles Manske]

Who busted this! It used to work!

Comment 20

[Charles Manske]

Attachment: Fixes case where of click selecting a single cell

Comment 21

[Charles Manske]

The final problem was that context click on a cell auto-selects the cell
if you click past the end of existing content or cell is empty (you
don't actually see the cell selection hightlightin, no sure why! But it
doesn't really matter when context popup is used; it shows after you are done.)
The "JoinTableCells" command didn't do anything if just one cell was selected,
but we should join with cell to right in that case. Simple fix -- just check
if there's a second cell selected.

Comment 22

[kinmoz]

sr=[e-mail] with the one change I suggested on AIM.

Comment 23

[Charles Manske]

Attachment: Update with kin's suggested change

Comment 24

[mjudge]

r=mjudge

Comment 25

[Charles Manske]

checked in.

Comment 26

[sujay]

verified in 6/18 build.