559939 - HTML5 <video> container should have a context menu on Fennec (mobile)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tobias (:Tobbi) Markus]

When opening a HTML5 video site with current trunk build of Fennec, I found out that it has no context menu at all.

This is a difference to Firefox, where the context menu contains items like Play, Pause, Restart, Full Screen, Copy video URL, and much more.

I think it should be available on Fennec too (at least the most important of them, keeping in mind that space is limited on mobile)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava ?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

related to bug 465839

Comment 3

[Aakash Desai [:aakashd]]

We can't really fix the context menu issue until we have controls for the feature, so I'm marking this as dependent on the bug mentioned in comment #2

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: part 1

As a start, this adds a context menu for video elements with "Share Video" and "Save Video" commands:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#806

We could add Play/Pause, but it would require a little extra code to send messages back to the child process.  I haven't done this yet because Madhava suggested just using single-tap for play/pause.

It looks like full-screen needs more code too.  Firefox uses an HTML page and openDialog to do full-screen:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#807

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 469148 [details] [diff] [review]
part 1

This is a good start.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 469148 [details] [diff] [review]
part 1

Pushed: http://hg.mozilla.org/mobile-browser/rev/5543b742f8b3

Comment 7

[Matt Brubeck (:mbrubeck)]

Filed followup bug 590719 for play/pause and bug 590715 for fullscreen.

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100826 Namoroka/4.0b5pre Fennec/2.0a1pre

Comment 9

[Aaron Train [:aaronmt]]

https://litmus.mozilla.org/show_test.cgi?id=12895