For multiple authors, we should list "others" after the 2nd author in the attribution line

VERIFIED FIXED in 5.12.3

Status

addons.mozilla.org Graveyard
Public Pages
P5
trivial
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: stephend, Assigned: Barry Chen)

Tracking

Bug Flags:
in-testsuite ?

Details

(Whiteboard: [z], URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
STR:

1. Load https://preview.addons.mozilla.org/z/en-US/firefox/extensions/web-development/
2. Look at the Firebug add-on's attribution line:

"by Joe Hewitt, Justin Dolske, robcee, johnjbarton, FirebugWorkingGroup"

That should read by "Joe Hewitt, Justin Dolske, others"

(Compare to https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:4)
(Reporter)

Comment 1

8 years ago
Created attachment 439625 [details]
Screenshot of current (Zamboni)
(Reporter)

Comment 2

8 years ago
Created attachment 439626 [details]
Screenshot of expected

Comment 3

8 years ago
same behavior can be seen on search results,add-on detail page-

https://preview.addons.mozilla.org/en-US/firefox/addon/5334/
On the add-on detail page we should list all authors (as we do now).  On search pages and listing pages, we should truncate at 2 with an "others".  Be sure to add an l10n comment for "others" so localizers know it's part of a list.
Assignee: nobody → chenba
Severity: major → trivial
Priority: -- → P5
Target Milestone: --- → 5.12.3
(Assignee)

Comment 5

7 years ago
Committed @ https://github.com/chenba/zamboni/commit/4e8001279c728c9a6107461d8583e455ec66f2c5

Affects listing pages and category landing page.
(Assignee)

Comment 6

7 years ago
Changes based on jbalogh's protips: https://github.com/chenba/zamboni/commit/1aada3ca709510fb26bc31b649a0587c865f50c1
(Assignee)

Comment 7

7 years ago
Pushed to jbalogh/master: https://github.com/jbalogh/zamboni/commit/1aada3ca709510fb26bc31b649a0587c865f50c1
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Updated

7 years ago
Flags: in-testsuite?
(Reporter)

Comment 8

7 years ago
Verified FIXED on:

* https://addons.allizom.org/en-US/firefox/extensions/web-development/ ("others")
* https://addons.allizom.org/en-US/firefox/search/?q=firebug&cat=all&lver=any&pid=1&sort=&pp=20&lup=&advanced= ("others")
* https://addons.allizom.org/en-US/firefox/addon/1843/ (full list of authors)
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.