Remove names from getters and setters in mail/ and mailnews/

RESOLVED FIXED in Thunderbird 3.1b2

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

Trunk
Thunderbird 3.1b2

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Bug 517580 seems to have removed named getters using the get syntax from SpiderMonkey. We should get rid of them as well.
(Assignee)

Comment 1

9 years ago
(and setters too)
Summary: Remove named getters from mail/ and mailnews/ → Remove named getters and setters from mail/ and mailnews/
(Assignee)

Comment 2

9 years ago
Created attachment 439681 [details] [diff] [review]
patch

The URL I linked to isn't comprehensive, but the two regexes "^ *(get|set) +[A-Za-z_]+ +[A-Za-z_]+" (single line) and "^ *(get|set) +[A-Za-z_]+ *$" (multi-line definition) should cover all the cases we have. I've verified with egrep that those two regexes don't match anything else in either mail/ or mailnews/.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #439681 - Flags: superreview?(bienvenu)
Attachment #439681 - Flags: review?(bugmail)
Attachment #439681 - Flags: review?(bugmail) → review+

Updated

9 years ago
Attachment #439681 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 3

9 years ago
[clarified the summary a little]

http://hg.mozilla.org/comm-central/rev/2897f71b5ce2
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Summary: Remove named getters and setters from mail/ and mailnews/ → Remove names from getters and setters in mail/ and mailnews/
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.