jsgcchunk.o does not compile

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Wesley W. Garland, Unassigned)

Tracking

1.9.2 Branch
All
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 439778 [details] [diff] [review]
Patch which changes #if to #if defined

My compilation environment is Solaris 10, gcc 4.3.4, but I am certain this will affect other platforms:

/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:259:24: error: #if with no expression
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp: In function 'void* js::AllocGCChunk()':
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:270: error: 'MapPages' was not declared in this scope

This was introduced when bug 553812 landed
(Reporter)

Updated

7 years ago
Attachment #439778 - Flags: review?(jorendorff)
(Reporter)

Updated

7 years ago
Attachment #439778 - Attachment is patch: true
Attachment #439778 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 439778 [details] [diff] [review]
Patch which changes #if to #if defined

This is about right. I'll change '#if defined' to #ifdef and push it on Monday, if there are no objections.
Attachment #439778 - Flags: review?(jorendorff) → review+
(Reporter)

Comment 2

7 years ago
Was this pushed?
(Reporter)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.