Closed
Bug 560116
Opened 15 years ago
Closed 13 years ago
jsgcchunk.o does not compile
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wes, Unassigned)
Details
Attachments
(1 file)
|
642 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
My compilation environment is Solaris 10, gcc 4.3.4, but I am certain this will affect other platforms:
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:259:24: error: #if with no expression
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp: In function 'void* js::AllocGCChunk()':
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:270: error: 'MapPages' was not declared in this scope
This was introduced when bug 553812 landed
|
Reporter | |
Updated•15 years ago
|
Attachment #439778 -
Flags: review?(jorendorff)
|
|
Reporter | |
Updated•15 years ago
|
Attachment #439778 -
Attachment is patch: true
Attachment #439778 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 1•15 years ago
|
||
Comment on attachment 439778 [details] [diff] [review]
Patch which changes #if to #if defined
This is about right. I'll change '#if defined' to #ifdef and push it on Monday, if there are no objections.
Attachment #439778 -
Flags: review?(jorendorff) → review+
|
|
Reporter | |
Comment 2•15 years ago
|
||
Was this pushed?
|
|
Reporter | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•