Last Comment Bug 560116 - jsgcchunk.o does not compile
: jsgcchunk.o does not compile
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: 1.9.2 Branch
: All Solaris
-- critical (vote)
: ---
Assigned To: general
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2010-04-18 08:22 PDT by Wesley W. Garland
Modified: 2011-10-20 09:46 PDT (History)
0 users
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch which changes #if to #if defined (642 bytes, patch)
2010-04-18 08:22 PDT, Wesley W. Garland
jorendorff: review+
Details | Diff | Splinter Review

Description User image Wesley W. Garland 2010-04-18 08:22:48 PDT
Created attachment 439778 [details] [diff] [review]
Patch which changes #if to #if defined

My compilation environment is Solaris 10, gcc 4.3.4, but I am certain this will affect other platforms:

/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:259:24: error: #if with no expression
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp: In function 'void* js::AllocGCChunk()':
/export/home/wes/hg/tracemonkey/js/src/jsgcchunk.cpp:270: error: 'MapPages' was not declared in this scope

This was introduced when bug 553812 landed
Comment 1 User image Jason Orendorff [:jorendorff] 2010-04-18 08:27:08 PDT
Comment on attachment 439778 [details] [diff] [review]
Patch which changes #if to #if defined

This is about right. I'll change '#if defined' to #ifdef and push it on Monday, if there are no objections.
Comment 2 User image Wesley W. Garland 2010-06-17 08:56:46 PDT
Was this pushed?

Note You need to log in before you can comment on or make changes to this bug.