Closed
Bug 560127
Opened 15 years ago
Closed 15 years ago
nsMediaDecoder::nsMediaDecoder doesn't initialize mFramerate
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: cajbir)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(2 obsolete files)
Defined as a variable in:
* content/media/nsMediaDecoder.h
o line 283 -- float mFramerate;
* content/media/ogg/nsOggReader.h
o line 325 -- float mFramerate;
Referenced in:
* content/media/ogg/nsOggReader.h (View Hg log or Hg annotations)
o line 314 -- : mFramerate(0.0),
* content/media/ogg/nsOggReader.cpp
o line 1335 -- aInfo.mFramerate = mTheoraState->mFrameRate;
Assignee | ||
Comment 2•15 years ago
|
||
I'm pretty sure mFramerate in nsMediaDecoder can just be removed from the header file. It probably got left out during a refactoring. I'll check and do a patch if that's the case later today.
Assignee | ||
Comment 3•15 years ago
|
||
Assignee: timeless → chris.double
Attachment #439867 -
Attachment is obsolete: true
Attachment #440108 -
Flags: review?(chris)
Attachment #439867 -
Flags: review?(chris.double)
Comment 4•15 years ago
|
||
Comment on attachment 440108 [details] [diff] [review]
Remove mFramerate from nsMediaDecoder
Looks like mFrameRate in its various incarnations is actually never used, just stored: http://mxr.mozilla.org/mozilla-central/search?string=mframerate
It was probably made obsolete when I added nsTheoraState::mFrameDuration. Oops!
We should just remove all instances of mFrame{r,R}ate, we don't need them.
Assignee | ||
Comment 5•15 years ago
|
||
See bug 568431 which will be removing mFramerate from the backend code.
Depends on: 568431
Assignee | ||
Updated•15 years ago
|
Attachment #440108 -
Attachment is obsolete: true
Attachment #440108 -
Flags: review?(chris)
Comment 6•15 years ago
|
||
Fixed by bug 568431 landing.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•