560127 - nsMediaDecoder::nsMediaDecoder doesn't initialize mFramerate

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[timeless]

Defined as a variable in:
    * content/media/nsMediaDecoder.h
          o line 283 -- float mFramerate; 

    * content/media/ogg/nsOggReader.h
          o line 325 -- float mFramerate; 

Referenced in:
    * content/media/ogg/nsOggReader.h (View Hg log or Hg annotations)
          o line 314 -- : mFramerate(0.0), 
    * content/media/ogg/nsOggReader.cpp
          o line 1335 -- aInfo.mFramerate = mTheoraState->mFrameRate;

Comment 1

[timeless]

Attachment: patch

Comment 2

[cajbir (:cajbir)]

I'm pretty sure mFramerate in nsMediaDecoder can just be removed from the header file. It probably got left out during a refactoring. I'll check and do a patch if that's the case later today.

Comment 3

[cajbir (:cajbir)]

Attachment: Remove mFramerate from nsMediaDecoder

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 440108 [details] [diff] [review]
Remove mFramerate from nsMediaDecoder

Looks like mFrameRate in its various incarnations is actually never used, just stored: http://mxr.mozilla.org/mozilla-central/search?string=mframerate

It was probably made obsolete when I added nsTheoraState::mFrameDuration. Oops!

We should just remove all instances of mFrame{r,R}ate, we don't need them.

Comment 5

[cajbir (:cajbir)]

See bug 568431 which will be removing mFramerate from the backend code.

Comment 6

[Matthew Gregan [:kinetik]]

Fixed by bug 568431 landing.