Closed Bug 560127 Opened 11 years ago Closed 11 years ago

nsMediaDecoder::nsMediaDecoder doesn't initialize mFramerate

Categories

(Core :: Audio/Video, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: cajbir)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(2 obsolete files)

Defined as a variable in:
    * content/media/nsMediaDecoder.h
          o line 283 -- float mFramerate; 

    * content/media/ogg/nsOggReader.h
          o line 325 -- float mFramerate; 

Referenced in:
    * content/media/ogg/nsOggReader.h (View Hg log or Hg annotations)
          o line 314 -- : mFramerate(0.0), 
    * content/media/ogg/nsOggReader.cpp
          o line 1335 -- aInfo.mFramerate = mTheoraState->mFrameRate;
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #439867 - Flags: review?(chris.double)
I'm pretty sure mFramerate in nsMediaDecoder can just be removed from the header file. It probably got left out during a refactoring. I'll check and do a patch if that's the case later today.
Assignee: timeless → chris.double
Attachment #439867 - Attachment is obsolete: true
Attachment #440108 - Flags: review?(chris)
Attachment #439867 - Flags: review?(chris.double)
Comment on attachment 440108 [details] [diff] [review]
Remove mFramerate from nsMediaDecoder

Looks like mFrameRate in its various incarnations is actually never used, just stored: http://mxr.mozilla.org/mozilla-central/search?string=mframerate

It was probably made obsolete when I added nsTheoraState::mFrameDuration. Oops!

We should just remove all instances of mFrame{r,R}ate, we don't need them.
See bug 568431 which will be removing mFramerate from the backend code.
Depends on: 568431
Attachment #440108 - Attachment is obsolete: true
Attachment #440108 - Flags: review?(chris)
Fixed by bug 568431 landing.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.