Closed Bug 560138 Opened 10 years ago Closed 10 years ago

mismatch use of new[] with delete in CData::Create

Categories

(Core :: js-ctypes, defect, P1)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file)

5113 CData::Create(JSContext* cx,
5166     data = new char[size];
5183       delete data;
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Priority: -- → P1
Attached patch patchSplinter Review
Assignee: dwitte → timeless
Attachment #439860 - Flags: review?(dwitte)
Comment on attachment 439860 [details] [diff] [review]
patch

r=dwitte
Attachment #439860 - Flags: review?(dwitte) → review+
Comment on attachment 439860 [details] [diff] [review]
patch

Waitasec, you (mis)matched the wrong one:

This one also needs matching: http://mxr.mozilla.org/mozilla-central/source/js/src/ctypes/CTypes.cpp#5183

r=dwitte for that one instead. ;)
Attachment #439860 - Flags: review+ → review-
Also, when you land, please do so on TM rather than m-c.
http://hg.mozilla.org/tracemonkey/rev/d87701b07ca9

Pushed corrected fix.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.