Closed Bug 560139 Opened 10 years ago Closed 10 years ago

jsdStackFrame::Eval leaks estate when failing to use ContextStack

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

862 bytes, patch
jorendorff
: review+
Details | Diff | Splinter Review
1952 jsdStackFrame::Eval (const nsAString &bytes, const nsACString &fileName,
1972     estate = JS_SaveExceptionState (cx);

1976     nsCOMPtr<nsIJSContextStack> stack = do_GetService("@mozilla.org/js/xpc/ContextStack;1", &rv);
1977     if (NS_FAILED(rv))
1978         return rv;
1979     rv = stack->Push(cx);
1980     if (NS_FAILED(rv))
1981         return rv;

1995     JS_RestoreExceptionState (cx, estate);
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #439862 - Flags: review?(jorendorff)
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/9f57684dd42a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.