560193 - unable to delete newsgroup saved search

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[:glob ✱]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4

i am unable to delete a newsgroup filtering saved search.

there is no option to delete the saved search in the context menu, and clicking 'unsubscribe' does nothing.

Reproducible: Always

Steps to Reproduce:
1. search a newsgroup
2. create a saved search from the results
3. right-click on the search and look for 'delete'

Actual Results:  
no delete option

Expected Results:  
the ability to delete saved searches

Comment 1

[Ludovic Hirlimann [:Usul]]

Anything in Tools -> error console ?

Comment 2

[:glob ✱]

nothing in the error console.

should there be a "delete" item in the context menu?

Comment 3

[David :Bienvenu]

I believe the issue is that we don't allow delete of newsgroups, and because the saved search is under a news server, we mistakenly think it's a newsgroup and don't allow delete of it.

Comment 4

[:glob ✱]

until this bug is resolved, is there a way to manually delete the searches?

Comment 5

[:aceman]

You can manually remove it from the file virtualFolders.dat in your TB profile.

If this is just a wrong condition in the context menu as comment 3 suggests, I can try this.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to :aceman from comment #5)
> You can manually remove it from the file virtualFolders.dat in your TB
> profile.
> 
> If this is just a wrong condition in the context menu as comment 3 suggests,
> I can try this.

also missing from file menu

Comment 7

[:aceman]

This is probably caused by the fact that we apparently allow search folders in a news account by mistake. Some code allows them there, but other parts are not prepared for that and don't offer the related actions.

Comment 8

[:aceman]

Attachment: patch

OK, let's try this. I don't know why the logic for the context menu and the File menu is so different. So I had to change it at several places.

Hopefully it does not open a can of worms. But we need a delete command until we properly prevent creating of Saved search under news or reimplement saved searches to be on a level above the actual accounts (as discussed in other bugs).

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 8362716 [details] [diff] [review]
patch

Review of attachment 8362716 [details] [diff] [review]:
-----------------------------------------------------------------

The menus still talk about unsubscribe. Could you fix that too?

::: mail/base/content/mail3PaneWindowCommands.js
@@ +286,1 @@
>              return CanDeleteFolder(folder);

drop the else

Comment 10

[:aceman]

It looks like bug 878805 finally prevented creating search folders under news. So this patch just complements it and allows the user to clean up any existing ones.

Comment 11

[:aceman]

Attachment: patch v2

This removes the Unsubscribe item when over a search folder. Fixes also the "Newsgroup properties" item in Edit menu.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 8368202 [details] [diff] [review]
patch v2

Review of attachment 8368202 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=mkmelin
I do get an error to console when selecting such a folder, but it doesn't appear to be related to this

::: mail/base/content/mail3PaneWindowCommands.js
@@ +285,2 @@
>              return CanDeleteFolder(folder);
> +          }

no return in else, just fall through an return

Comment 13

[:aceman]

Attachment: patch final

Thanks.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/04b872817043