Closed
Bug 560258
Opened 14 years ago
Closed 14 years ago
Standalone Ogg Audio is not previewed correctly in Page Info > Media
Categories
(Firefox :: Page Info Window, defect)
Firefox
Page Info Window
Tracking
()
RESOLVED
FIXED
Firefox 4.0b1
People
(Reporter: mozilla.bugs, Assigned: mozilla.bugs)
References
()
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
db48x
:
review+
|
Details | Diff | Splinter Review |
I just looked at http://upload.wikimedia.org/wikipedia/commons/7/7b/Ochi_chernie.ogg and I realized that since it is opened as a standalone element, Firefox lists it as a Video, which Page Info forces to be 0px x 0px, which means that it can't be played.
|
Assignee | |
Updated•14 years ago
|
OS: Windows Vista → All
Hardware: x86 → All
|
|
Assignee | |
Comment 1•14 years ago
|
||
I dropped the resizing of ogg videos, since it caused this problem, and since resizing of videos is probably very rare, this doesn't matter having it resized in the Page Info window in the way that it matters for images. Besides it makes the code shorter...
|
|
Assignee | |
Updated•14 years ago
|
Summary: Standalone Ogg Audio is not listed correctly in Page Info > Media → Standalone Ogg Audio is not previewed correctly in Page Info > Media
|
||
Comment 2•14 years ago
|
||
Comment on attachment 449120 [details] [diff] [review] Patch v. 1.0 yea, looks good. r=db48x
Attachment #449120 -
Flags: review?(dao) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•14 years ago
|
||
I'll check this in for you, just attach an export of your commit (so that you get proper attribution for it).
|
|
||
Comment 4•14 years ago
|
||
checked this in a little while ago
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1244bf803057
Target Milestone: --- → Firefox 3.7a6
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: Firefox 3.7a6 → Firefox 3.7a5
|
||
Updated•14 years ago
|
Target Milestone: Firefox 3.7a5 → Firefox 3.7a6
You need to log in
before you can comment on or make changes to this bug.
Description
•