Closed
Bug 560276
Opened 14 years ago
Closed 14 years ago
sampling testcase getSamples() can return Delete object samples after clearSamples()
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dschaffe, Unassigned)
Details
Attachments
(1 file)
|
726 bytes,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
from email treilly: This test appears to be broken. The assumption is that when sampling is paused we generate no samples but there is one exception which is that we generate deleted object samples b/c the objects may have been created when sampling was enabled. B/c AddTestCase performs an allocation its possible for a GC activity to occur which can lead to deleted object samples. Perhaps the test can be modified to check that there are no samples or that they are all deleted object samples.
|
Reporter | |
Comment 1•14 years ago
|
||
added a patch not count DeleteObjectSample types in getSamples() after clearSamples()
Attachment #439977 -
Flags: review?(treilly)
|
||
Updated•14 years ago
|
Attachment #439977 -
Flags: review?(treilly) → review+
|
|
Reporter | |
Comment 2•14 years ago
|
||
pushed in tr-argo: 4009:3a881efd8d52 tr: 4531:3a881efd8d52
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•