Do not display deleted attachments in "View All"

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
Attachments & Requests
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Kevin Roberts, Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 3.6
Bug Flags:
approval +
approval3.6 +

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2) Gecko/20100115 Firefox/3.6

Bugzilla interface shows up in frame of deleted attachments in View All

If you allow attachment deletion and, as Admin, delete an obsolete attachment. The bugzilla interface shows up in the deleted bug's frame when you select View All (see attachment)

Reproducible: Always

Steps to Reproduce:
1. In Administration > Parameters > Attachments, enable allow_attachment_display and allow_attachment_deletion
2. Select bug with obsolete attachments
3. Click on Show Obsolete link in the Attachments block
4. Click on the Details link next to an obsolete attachment
5. Click on the Delete link in the Actions line at the bottom
6. Confirm delete when asked
7. Back up to screen with Attachment block, and click on the View All link in the lower, right corner of the block

Actual Results:  
Get list of attachments with graphics displayed in frame below each listed attachment. However, the deleted item show the Bugzilla interface inside the frame with big red allert saying "The attachment you are attempting to access has been removed." This is an the actual interface with click-able links.

Expected Results:  
List of items with deleted items removed, or records including ones saying the item was removed, but it should NOT include the Bugzilla interface in the frame.
(Reporter)

Comment 1

8 years ago
Created attachment 439982 [details]
Screen capture showing Bugzilla interface inside deleted attachment frame
(Assignee)

Updated

8 years ago
Severity: normal → minor
OS: Windows XP → All
Hardware: x86 → All
(Assignee)

Comment 2

8 years ago
Created attachment 445729 [details] [diff] [review]
patch, v1

Let's ignore deleted attachments as there is nothing to see.
Assignee: attach-and-request → LpSolit
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #445729 - Flags: review+
(Assignee)

Comment 3

8 years ago
Let's take it for 3.6.1 too. a=me as module owner.
Flags: approval3.6+
Flags: approval+
Target Milestone: --- → Bugzilla 3.6
(Assignee)

Comment 4

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified attachment.cgi
Committed revision 7177.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified attachment.cgi
Committed revision 7098.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Summary: Bugzilla interface shows up in frames of deleted attachments in View All → Do not display deleted attachments in "View All"
You need to log in before you can comment on or make changes to this bug.