Closed Bug 560284 Opened 16 years ago Closed 16 years ago

*All* errors that checksetup.pl throws should be colorized

Categories

(Bugzilla :: Installation & Upgrading, enhancement)

3.4.6
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.0

People

(Reporter: mkanat, Assigned: mkanat)

References

Details

Attachments

(1 file)

Right now there are a lot of errors, like the foreign key errors, that can too-easily be missed by users who are upgrading or installing their Bugzilla. They should be in red, just like the requirement errors.
Attached patch v1Splinter Review
Okay, I accomplished this by creating a __DIE__ handler that colorizes its messages if we're not in an eval, and installing it during init_console, and then changing all errors to use "die" instead of print/exit.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #440042 - Flags: review+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Constants.pm modified Bugzilla/DB.pm modified Bugzilla/DB/Mysql.pm modified Bugzilla/Install/DB.pm modified Bugzilla/Install/Requirements.pm modified Bugzilla/Install/Util.pm Committed revision 7131.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Blocks: 575475
Keywords: relnote
Added to the release notes in bug 604256.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: