Closed Bug 560300 Opened 10 years ago Closed 10 years ago

Remove dead NJ_PROFILE code

Categories

(Core Graveyard :: Nanojit, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)

Attachments

(2 files, 1 obsolete file)

From what I can tell, nothing enabled by NJ_PROFILE=1 is ever used in TR or TM.
Target Milestone: --- → Future
TR patch.  Should not land until nanojit changes are merged in, otherwise removing this flag will enable NJ_PROFILE code in release mode.
Assignee: nobody → edwsmith
Status: NEW → ASSIGNED
Attachment #439993 - Flags: review?(rreitmai)
Attachment #439994 - Flags: review?(nnethercote)
Removed some accidental unrelated changes.
Attachment #439994 - Attachment is obsolete: true
Attachment #439995 - Flags: review?(nnethercote)
Attachment #439994 - Flags: review?(nnethercote)
Blocks: 555255
Comment on attachment 439995 [details] [diff] [review]
(v2) Removes NJ_PROFILE and related code, since it's all dead.

Looks fine, compiles and passes TM trace-tests.
Attachment #439995 - Flags: review?(nnethercote) → review+
Attachment #439993 - Flags: review?(rreitmai) → review+
NJ: http://hg.mozilla.org/projects/nanojit-central/rev/02bc396c1339
Whiteboard: fixed-in-nanojit
Comment on attachment 439995 [details] [diff] [review]
(v2) Removes NJ_PROFILE and related code, since it's all dead.

TR: http://hg.mozilla.org/tamarin-redux/rev/3e6f00bb55d4
Comment on attachment 439993 [details] [diff] [review]
Don't reference NJ_PROFILE in TR

TR: http://hg.mozilla.org/tamarin-redux/rev/f455fb80e50f
Assignee: edwsmith → nobody
TM: http://hg.mozilla.org/tracemonkey/rev/76fad76804f9
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/76fad76804f9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.