Closed
Bug 560300
Opened 14 years ago
Closed 14 years ago
Remove dead NJ_PROFILE code
Categories
(Core Graveyard :: Nanojit, defect)
Core Graveyard
Nanojit
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: edwsmith, Unassigned)
References
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey)
Attachments
(2 files, 1 obsolete file)
|
451 bytes,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
|
5.65 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
From what I can tell, nothing enabled by NJ_PROFILE=1 is ever used in TR or TM.
|
Reporter | |
Updated•14 years ago
|
Target Milestone: --- → Future
|
|
Reporter | |
Comment 1•14 years ago
|
||
TR patch. Should not land until nanojit changes are merged in, otherwise removing this flag will enable NJ_PROFILE code in release mode.
|
|
Reporter | |
Comment 2•14 years ago
|
||
Attachment #439994 -
Flags: review?(nnethercote)
|
|
Reporter | |
Comment 3•14 years ago
|
||
Removed some accidental unrelated changes.
Attachment #439994 -
Attachment is obsolete: true
Attachment #439995 -
Flags: review?(nnethercote)
Attachment #439994 -
Flags: review?(nnethercote)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 439995 [details] [diff] [review] (v2) Removes NJ_PROFILE and related code, since it's all dead. Looks fine, compiles and passes TM trace-tests.
Attachment #439995 -
Flags: review?(nnethercote) → review+
|
||
Updated•14 years ago
|
Attachment #439993 -
Flags: review?(rreitmai) → review+
|
|
Reporter | |
Comment 5•14 years ago
|
||
NJ: http://hg.mozilla.org/projects/nanojit-central/rev/02bc396c1339
Whiteboard: fixed-in-nanojit
|
|
Reporter | |
Comment 6•14 years ago
|
||
Comment on attachment 439995 [details] [diff] [review] (v2) Removes NJ_PROFILE and related code, since it's all dead. TR: http://hg.mozilla.org/tamarin-redux/rev/3e6f00bb55d4
|
|
Reporter | |
Comment 7•14 years ago
|
||
Comment on attachment 439993 [details] [diff] [review] Don't reference NJ_PROFILE in TR TR: http://hg.mozilla.org/tamarin-redux/rev/f455fb80e50f
|
|
Reporter | |
Updated•14 years ago
|
Assignee: edwsmith → nobody
|
|
||
Comment 8•14 years ago
|
||
TM: http://hg.mozilla.org/tracemonkey/rev/76fad76804f9
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin, fixed-in-tracemonkey
|
||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/76fad76804f9
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•